In the 'Highlighting' processor, the search keys are not escaped for special characters. This can break the regular expression.

An example query that is not properly escaped: 'drupal + search_api'

CommentFileSizeAuthor
#4 2159011-4--highlighting_preg_quote.patch777 bytesdrunken monkey
#1 search_api-escape-highlighting-input-2159011-1.patch840 bytesidebr

Comments

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new search_api-escape-highlighting-input-2159011-1.patch840 bytes

Attached patch preg_quotes the search keys before the keys are inserted into the regular expression

idebr’s picture

idebr commented
Issue summary: View changes
idebr’s picture

idebr commented
Issue summary: View changes
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2159011-4--highlighting_preg_quote.patch777 bytes

Ah, you're right! Thanks for spotting this and providing a fix! Don't know how that slipped past me, with regular expressions I'm normally extra-careful …
Anyways, I think the attached form of the patch is more readable, the foreach loop can easily be replaced by a array_map() call.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: Framework » Plugins
idebr’s picture

idebr commented

Yes, that is definitely better than #1. Simple and elegant, I like it!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Excellent, good to hear!
Committed.
Thanks again for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.