Deprecate comment_int_to_alphadecimal() & comment_alphadecimal_to_int() in favour of methods in Number component

Good idea

1. +++ b/core/modules/comment/lib/Drupal/comment/Entity/Comment.php
   @@ -462,4 +462,21 @@ public static function preCreate(EntityStorageControllerInterface $storage_contr
   +  /**
   +   * {@inheritdoc}
   +   */
   +  public static function intToAlphadecimal($i = 0) {
   +    $num = base_convert((int) $i, 10, 36);
   +    $length = strlen($num);
   +
   +    return chr($length + ord('0') - 1) . $num;
   +  }
   +
   +  /**
   +   * {@inheritdoc}
   +   */
   +  function alphadecimalToInt($c = '00') {
   +    return base_convert(substr($c, 1), 36, 10);
   +  }
   +
   

   Should we be unit testing these, or at the very least opening a followup to do so?

2. +++ b/core/modules/comment/comment.module
   @@ -1584,6 +1584,8 @@ function _comment_per_page() {
      $num = base_convert((int) $i, 10, 36);
   
   @@ -1595,7 +1597,7 @@ function comment_int_to_alphadecimal($i = 0) {
      return base_convert(substr($c, 1), 36, 10);
   

   Shouldn't this just wrap the code in Comment?

+++ b/core/modules/comment/lib/Drupal/comment/Entity/Comment.php
@@ -462,4 +462,21 @@ public static function preCreate(EntityStorageControllerInterface $storage_contr
+  function alphadecimalToInt($c = '00') {
+    return base_convert(substr($c, 1), 36, 10);
...
+
...
+  }

+++ b/core/modules/comment/lib/Drupal/comment/CommentInterface.php
@@ -35,4 +35,28 @@
+  public static function intToAlphadecimal($i = 0);
...
+  function alphadecimalToInt($c = '00');

Both are static methods which I think we really don't have to put into the interface.

+++ b/core/modules/comment/comment.module
@@ -1584,6 +1584,8 @@ function _comment_per_page() {
   $num = base_convert((int) $i, 10, 36);

@@ -1595,7 +1597,7 @@ function comment_int_to_alphadecimal($i = 0) {
   return base_convert(substr($c, 1), 36, 10);

Shouldn't the old functions just wrap the new ones?

Not sure on the group name in the new test's getInfo method, should it be common instead of commons?
Other than that rtbc.

Thanks

Committed/pushed to 8.x, thanks!

Still need to sort out the @deprecated tag but there's an issue open for that.

Opened #2187653: Remove comment_alphadecimal_to_int and comment_int_to_alphadecimal to remove these, as they are unused and comment_int_to_alphadecimal doesn't do what it's meant to.