Remove field_attach_preprocess()

Yup, RTBC if green. Thanks !

1: remove-field-attach-preprocess-2157153-1.patch queued for re-testing.

Patch #1 passed, should be styled green...
Requested a re-test.

I believe this is a beta blocker as a part of #2061107: Remove deprecated procedural functions in Field API. Bumping to major accordingly (and possibly it should be critical in the sense that it should block a beta release, but we don't entirely have consensus on that rule-of-thumb). We've made an explicit decision to remove the procedural cruft in the configurable field API because it has a pretty severe DX impact.

Also, this API change is presumably implicitly approved as a part of the overall issue. Let's have a core maintainer confirm to be sure. :)

Something is wrong, the patch is not finishing a test run even after repeated attempts. I SSH'd into the bot in question and there's nothing in the Apache error logs.

I would definitely try to install Drupal and run one or two related tests and observe. There is maybe a leftover call at a very awkward time?

Reroll, re-upload.

Ok, committed and pushed to 8.x. This can probably just be rolled into the change notice for #2061107: Remove deprecated procedural functions in Field API.

Agreed that it can go in the same change record, but we also need to reference both issues. :)

The change notices for #2061107: Remove deprecated procedural functions in Field API were added toi the existing notices for the respective APIs.

Created a separate change notice for this one : https://drupal.org/node/2168285

Thanks!