Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.See discussion in #2023571: Support preprocessing in EntityViewBuilder, the function is useless with the new render and Entity Field API.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | remove-field-attach-preprocess-2157153-10.patch | 6.05 KB | yched |
| #1 | remove-field-attach-preprocess-2157153-1.patch | 6.07 KB | Berdir |
Comments
Comment #1
BerdirHere is the patch.
Comment #2
yched CreditAttribution: yched commentedYup, RTBC if green. Thanks !
Comment #3
Berdir#2 set this to RTBC, why did the issue not update?
Comment #4
xjm1: remove-field-attach-preprocess-2157153-1.patch queued for re-testing.
Comment #5
yched CreditAttribution: yched commentedPatch #1 passed, should be styled green...
Requested a re-test.
Comment #6
xjmI believe this is a beta blocker as a part of #2061107: Remove deprecated procedural functions in Field API. Bumping to major accordingly (and possibly it should be critical in the sense that it should block a beta release, but we don't entirely have consensus on that rule-of-thumb). We've made an explicit decision to remove the procedural cruft in the configurable field API because it has a pretty severe DX impact.
Also, this API change is presumably implicitly approved as a part of the overall issue. Let's have a core maintainer confirm to be sure. :)
Comment #7
chx CreditAttribution: chx commentedSomething is wrong, the patch is not finishing a test run even after repeated attempts. I SSH'd into the bot in question and there's nothing in the Apache error logs.
Comment #9
chx CreditAttribution: chx commentedI would definitely try to install Drupal and run one or two related tests and observe. There is maybe a leftover call at a very awkward time?
Comment #10
yched CreditAttribution: yched commentedReroll, re-upload.
Comment #11
BerdirTestbot is happy again.
Comment #12
webchickOk, committed and pushed to 8.x. This can probably just be rolled into the change notice for #2061107: Remove deprecated procedural functions in Field API.
Comment #13
xjmAgreed that it can go in the same change record, but we also need to reference both issues. :)
Comment #14
yched CreditAttribution: yched commentedThe change notices for #2061107: Remove deprecated procedural functions in Field API were added toi the existing notices for the respective APIs.
Created a separate change notice for this one : https://drupal.org/node/2168285
Comment #15
xjmThanks!