Add ctools content type "Meta tags" to use in node/%node/edit and node/add pages, instead of original tab. Still haven't tested it yet ;-)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mitsuroseba’s picture

undertext’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: metatag-add_ctools_content_type-2156653.patch, failed testing.

mitsuroseba’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: metatag-add_ctools_content_type-2156653.patch, failed testing.

The last submitted patch, 1: metatag-add_ctools_content_type-2156653.patch, failed testing.

undertext’s picture

FileSize
2.54 KB
asgorobets’s picture

There is another issue in Metatag: Panels which has some settings for hiding submodules forms, it still needs work to handle submodules dynamically, but overall looks good
#1955414: Make the Metatag form setting as a content type
Don't know which one is duplicate. since Metatag: Panels was merged into Metatag.

DamienMcKenna’s picture

Component: Code » Panels integration
DamienMcKenna’s picture

Assigned: mitsuroseba » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: metatag-add_ctools_content_type-2156653-7.patch, failed testing.

asgorobets’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
3.02 KB

Fixed line endings

Status: Needs review » Needs work

The last submitted patch, 12: metatag-ctools-content-type-2156653-12.patch, failed testing.

The last submitted patch, 12: metatag-ctools-content-type-2156653-12.patch, failed testing.

DamienMcKenna’s picture

Status: Needs work » Needs review
FileSize
2.49 KB

Reroll.

Status: Needs review » Needs work

The last submitted patch, 15: metatag-n2156653-15.patch, failed testing.

DamienMcKenna’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
2.39 KB

Gah. I ran dos2unix on both files, hopefully it'll be ok now. I also tweaked it a little by adding an appropriate comment at the top of the file and changed the block/pane delta to be "metatag" rather than "meta-tags".

DamienMcKenna’s picture

Ok, glad it worked that time. Still need to test it, but it sounds great :)

sylus’s picture

Did some initial testing.

I tested with node/edit panel pages and placed the node form metatags element into the layout. I additionally gave it a panels collapsible style and worked as well. Can also point out that the "Node Being Edited" base form no longer rendered the metatags element once the new form element was placed so there was no duplication.

So overall worked great for me thanks!

  • DamienMcKenna committed bbcd5e3 on 7.x-1.x
    Issue #2156653 by mitsuroseba, undertext, asgorobets, DamienMcKenna:...
DamienMcKenna’s picture

Status: Needs review » Fixed

Committed, though I did move the plugin to the main Metatag module - it doesn't use the Panels integration, so best not to limit its usage.

Thank you all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.