This is the same issue I filed and patched for Views in 7.x #2154837: ajax_view.js has some extraneous code?
Drupal.views.ajaxView.prototype.attachPagerLinkAjax contains the following lines:
// Construct an object using the settings defaults and then overriding
// with data specific to the link.
$.extend(
viewData,
this.settings,
Drupal.Views.parseQueryString(href),
// Extract argument data from the URL.
Drupal.Views.parseViewArgs(href, this.settings.view_base_path)
);
// For anchor tags, these will go to the target of the anchor rather
// than the usual location.
$.extend(viewData, Drupal.Views.parseViewArgs(href, this.settings.view_base_path));I believe the second extend is extraneous as viewData was already extended by the same thing in the first extend.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | drupal8-remove-extraneous-code-2156295-9.patch | 624 bytes | rajendar reddy |
| #1 | remove-extraneous-code-2156295-1.patch | 683 bytes | vegantriathlete |
Comments
Comment #1
vegantriathleteComment #2
vegantriathleteComment #4
vegantriathleteThis is failing in the same way as the patch is failing for Views 7.x (and I'm pasting the same comments below from that issue just to make it easier to reference them directly here, in case somebody happens to look at this first).
Viewing the test results makes me wonder whether there is something wrong with Views or with the tests. I am not seeing anything that makes it clear to me where the error would be on my end. That's not to say that my change is not breaking something. I'm just saying that I would need help understanding what my change actually breaks.
When I tested this locally everything seemed to work exactly the same as before I made the change. So, it seems to work just fine to me and I don't understand why the change should fail the tests.
Can someone have a look at the test results and help me understand them better?
Comment #5
xjmMake sure to file any D8 issues against 8.x dev or no one will find them. :)
Comment #6
vegantriathlete1: remove-extraneous-code-2156295-1.patch queued for re-testing.
Comment #7
areke commented1: remove-extraneous-code-2156295-1.patch queued for re-testing.
Comment #9
rajendar reddy commentedUpdating patch with reroll. Please review.
Comment #10
alansaviolobo commentedpatch still applies. retesting.
Comment #13
nod_Nothing breaks in views.
Impressive a 1 years old patch still applies :p
Comment #14
alexpottCommitted 8759ddc and pushed to 8.0.x. Thanks!
Doing the same thing twice is a bug.