Add a way to provide meta tags specifically for 403 and 404 pages.

CommentFileSizeAuthor
#6 metatag-n2156261-6.patch8.42 KBDamienMcKenna
#2 error_metatags-2090557-2.patch4.03 KBplopesc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented

Hello

To do this, we can use a workaround with context_error and metatag_context modules for this pages.
However, if you consider it necessary, I could help with this feature request.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Active » Needs review
FileSize
error_metatags-2090557-2.patch4.03 KB

Attaching patch that could address this.

By default, it does not cache the results, but we could add the variable you mentioned in #2090557: Don't load/cache data on 403 & 404 error pages to allow cached values.

Regards.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

Nice, I'll review it tomorrow.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented

Could this feature be included in beta-8?

If you need any change, let me know.

Regards.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

I'll give it a test run tonight and will post a follow-up.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
metatag-n2156261-6.patch8.42 KB

I've changed it around a little bit. I realized that there's no point in not caching the 403/404 page output as the new structure results in only one cache object per 403 or 404 page, not an infinite number; I've also removed the now-unnecessary 'metatag_cache_error_pages' variable that only existed for a few weeks.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

Oh, also the patch in #6 adds several default values for the Open Graph, Dublin Core and Twitter Cards submodules; in each case the values are set to mimic what would be output on the homepage, i.e. if someone shared a 403 or 404 page on a social network they'll only get a link to the site's homepage, not the error page.

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented

Nice!
Thank you for your great work. If you need any help, just let me know ;)

HyperGlide’s picture

HyperGlide CreditAttribution: HyperGlide commented

@plopesc -- if wanna help -- then please test the patch ;-)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed! Thanks plopesc!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.