Updated: Comment #N

Problem/Motivation

Editor::label() indiscriminately loads the filter entity without storing it or anything. This struck me as odd, so I uploaded a patch replacing the method body with an exception, and it passed :) https://qa.drupal.org/pifr/test/687823

Proposed resolution

Remove the method completely. Entity::label() will be used.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
editor-label-remove.patch668 bytestim.plunkett

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

assuming bot agrees

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Seems fair. AFAICT calling ->label() will now return NULL. Which is fine, because the text format ID is available, so they can load that object themselves and then get that label.

RTBC+1

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.