Remove Editor::label() [#2155889]

Updated: Comment #N

Problem/Motivation

Editor::label() indiscriminately loads the filter entity without storing it or anything. This struck me as odd, so I uploaded a patch replacing the method body with an exception, and it passed :) https://qa.drupal.org/pifr/test/687823

Proposed resolution

Remove the method completely. Entity::label() will be used.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Comment	File	Size	Author
	editor-label-remove.patch	668 bytes	tim.plunkett

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 13 December 2013 at 06:08

Status:

Needs review

» Reviewed & tested by the community

assuming bot agrees

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 13 December 2013 at 08:05

Seems fair. AFAICT calling ->label() will now return NULL. Which is fine, because the text format ID is available, so they can load that object themselves and then get that label.

RTBC+1