The hook_commerce_customer_profile_type_info API call defines a help parameter. This text never actually shows up anywhere though. It should be showing up on profile add pages if you have the core help module enabled, but it does not.

The issue is that in the hook_help implementation it tries to use an argument from the path that is too high. The patch is simple and I will upload it shortly...

CommentFileSizeAuthor
#1 commerce_customer-show_help_text-2152273-0.patch1.16 KBacrazyanimal

Comments

acrazyanimal’s picture

acrazyanimal commented
StatusFileSize
new commerce_customer-show_help_text-2152273-0.patch1.16 KB
acrazyanimal’s picture

acrazyanimal commented
Status: Active » Needs review
sportel’s picture

sportel commented

Hi acrazyanimal,

I'm sorry, but the patch hasn't got any effect on the help text for me. It still doesn't show up.
(I've patched the file, cleared all caches, no effect)

acrazyanimal’s picture

acrazyanimal commented

Do you have the core help module enabled? and the system help block configured to display in your admin theme somewhere you can view it?

sportel’s picture

sportel commented

Yes, I have the core help module enabled and I tried the help block in different regions of my site, without any luck. It does work on your site?

acrazyanimal’s picture

acrazyanimal commented

Yes, it shows up for me in the admin theme. So for example to see the help text for myprofile type "test_profile" I go to admin/commerce/customer-profiles/add/test-profile and the block displays there at the top of the page.

The Bartik theme has a help region and the block is by default in that region for my test site.

sportel’s picture

sportel commented

My mistake!!! I didn't realize that the help text was only for the admin theme. Your patch works.
I assumed it was meant for every user (customer) who makes a new order and thus fills in a new customer profile. Isn't that what the help text is supposed to be for? When (as an admin) creating a new customer profile type, it says "Enter some help text to aid users in filling out the customer profile form on checkout." where the help text should be entered.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Works for me.

@sportel - there is no help text there by default. You'd have to either alter it in or else use a module that lets you define customer profile types with help text.

acrazyanimal’s picture

acrazyanimal commented

@sportel your question would be more appropriate in the customer_profile_type_ui issue related to this one. You are correct though that the description would make more sense. The latest dev version of the customer profile type ui module has updated help text for the 'help' parameter that makes this more clear. In terms of adding help on the profile edit forms, my suggestion is still to simply add a markup field to the profile and style it to look like help text or however you like.

I've added an issue to also update the commerce customer api descriptions for these parameters as well.

Thanks for committing Ryan. :)

sportel’s picture

sportel commented

@acrazyanimal,
Thanks for your help and work. I'll keep using a markup field to show some help text.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 1: commerce_customer-show_help_text-2152273-0.patch, failed testing.

rszrama’s picture

rszrama commented
Status: Needs work » Closed (fixed)