Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Issue #2152225 by steveoliver, joelpittet, hussainweb, shanethehat, jenlampton, kpa, AnythonyR, EVIIILJ, kgoel, Cottser, dsdeiz, hanpersand: Convert theme_select() to Twig
Task
Convert theme_select() to a Twig template.
Remaining tasks
- Patch
- Patch review
- Manual testing
- Profiling
Steps to test
@todo
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff.txt | 1.1 KB | longwave |
#9 | 2152225-twig-theme_select-9.patch | 2.21 KB | longwave |
Comments
Comment #1
star-szrAdding a commit message to the issue summary so the folks who already worked on #1898480: [meta] form.inc - Convert theme_ functions to Twig and in the Twig sandbox get credit.
Comment #2
JeroenTConverted theme_select to twig.
Patch attached.
Comment #4
JeroenT2: drupal-convert_theme_select_to_twig-2152225-2.patch queued for re-testing.
Comment #5
star-szrComment #6
star-szrFixing parent issue.
Comment #7
joelpittetHere is a manual test of http://d8.dev/admin/config/people/accounts/display
There is no difference in the markup except whitespace.
Comment #8
joelpittetSome nitpicks to take care of.
This should be Prepares variables for select element templates.
Needs a period.
Needs a colon ':' at the end of this line.
Don't write the variable types. This should be something like "The option element children." or something along those lines. https://drupal.org/node/1823416#datatypes
Comment #9
longwaveComment #10
joelpittetThanks @longwave! This is ready for profiling and then RTBC.
Comment #11
joelpittetScenario:
admin/structure/types/manage/article/form-display
with a datetime field too.
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=530ef14e56c65&...
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=530ef14e56c65&...
Comment #12
webchickCommitted and pushed to 8.x. Thanks!