Issue #2151101 by joelpittet, c4rl, IshaDakota, pplantinga, gnuget, longwave, jeanfei, sbudker1: Convert theme_status_report() to Twig

Task

Convert theme_status_report() to a Twig template.

Remaining tasks

  • Patch
  • Patch review
  • Manual testing
  • Profiling

Steps to test

@todo

CommentFileSizeAuthor
#1 2151101-1-twig-theme_status_report.patch4.72 KBjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2151101-1-twig-theme_status_report.patch4.72 KB

Split from system module's twig conversion.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue summary: View changes

Adding a commit message to the issue summary so the folks who already worked on #1987410: [meta] system.module - Convert theme_ functions to Twig and #1898454: system.module - Convert PHPTemplate templates to Twig (comment #41 and above aka @c4rl) get credit.

FelkerL’s picture

FelkerL commented
Issue tags: +SprintWeekend2014, +D8MA

Tested
the page "/admin/reports/status"

successfully.

Version "after" and "before" look identical.

idflood’s picture

idflood commented

Here are the profiling results for the patch in #1

=== 8.x..8.x compared (52e3d76a236c4..52e3d7d92c9cf):
ct  : 59,290|59,290|0|0.0%
wt  : 365,669|368,492|2,823|0.8%
cpu : 347,536|350,677|3,141|0.9%
mu  : 15,310,728|15,315,112|4,384|0.0%
pmu : 15,424,344|15,428,688|4,344|0.0%

=== 8.x..status-twig compared (52e3d76a236c4..52e3d8125a960):
ct  : 59,290|60,336|1,046|1.8%
wt  : 365,669|369,932|4,263|1.2%
cpu : 347,536|351,388|3,852|1.1%
mu  : 15,310,728|15,360,368|49,640|0.3%
pmu : 15,424,344|15,476,352|52,008|0.3%
idflood’s picture

idflood commented
Issue summary: View changes
Issue tags: -needs profiling

Also checked the markup and visually if there was any difference, looks good. The patch also looks fine.

I would mark this as RTBC but maybe someone with more twig experience could have a look at the patch.

maggo’s picture

maggo commented
Status: Needs review » Reviewed & tested by the community

The twig part looks good to me, there's not much you could do wrong there :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks! Another one bites the dust. :D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.