Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Issue #2151101 by joelpittet, c4rl, IshaDakota, pplantinga, gnuget, longwave, jeanfei, sbudker1: Convert theme_status_report() to Twig
Task
Convert theme_status_report() to a Twig template.
Remaining tasks
Patch- Patch review
Manual testingProfiling
Steps to test
@todo
Comment | File | Size | Author |
---|---|---|---|
#1 | 2151101-1-twig-theme_status_report.patch | 4.72 KB | joelpittet |
Comments
Comment #1
joelpittetSplit from system module's twig conversion.
Comment #2
star-szrAdding a commit message to the issue summary so the folks who already worked on #1987410: [meta] system.module - Convert theme_ functions to Twig and #1898454: system.module - Convert PHPTemplate templates to Twig (comment #41 and above aka @c4rl) get credit.
Comment #3
FelkerL CreditAttribution: FelkerL commentedTested
the page "/admin/reports/status"
successfully.
Version "after" and "before" look identical.
Comment #4
idflood CreditAttribution: idflood commentedHere are the profiling results for the patch in #1
Comment #5
idflood CreditAttribution: idflood commentedAlso checked the markup and visually if there was any difference, looks good. The patch also looks fine.
I would mark this as RTBC but maybe someone with more twig experience could have a look at the patch.
Comment #6
maggo CreditAttribution: maggo commentedThe twig part looks good to me, there's not much you could do wrong there :)
Comment #7
webchickCommitted and pushed to 8.x. Thanks! Another one bites the dust. :D