Now that plugins are picked up in subdirs, we can do away with D6Variable and put it back in d6/Variable where it belongs. As plugins are picked up by the system by plugin id this is a trivial even BC patch so I am RTBC'ing my own. The only change here is the unit test which doesn't have the entity manager to rely on.

CommentFileSizeAuthor
move_variable.patch2.38 KBchx

Comments

chx’s picture

chx commented
Status: Reviewed & tested by the community » Needs review

Apparently the bot doesn't pick RTBC patches?

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Back to where it belongs.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, move_variable.patch, failed testing.

The last submitted patch, move_variable.patch, failed testing.

chx’s picture

chx commented
Status: Needs work » Needs review

move_variable.patch queued for re-testing.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

OK, back to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

It still would be good to have at least a +1 on this patch from someone else on the migrate team. It seems harmless enough, but we've definitely introduced issues with innocent looking patches, and it's good to know that you're on the same page with others on the team regarding where these things are located.

Crossing my fingers anyway and committing and pushing to 8.x.

chx’s picture

chx commented

This is the list of sources before the frst core patch in the d6 directory. This is why I said "belongs": http://drupalcode.org/sandbox/chx/2105305.git/tree/625fae75c0b47fac36dd5... every other one is already there; it was moved out so we can have a core patch; the rest stayed in d6 because they are not in active use yet just unit tested and unit testing worked in a subdir.

Edit: and yes, as you can see Variable was there too.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

Looks good to me!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.