Updated: Comment 0

Problem/Motivation

There are a couple of local tasks left, of which #2032309: Use local tasks derivatives to provide local tasks for views fixes quite a couple of them.

Proposed resolution

Let's remove the rest of theme here and maybe even kill the actual code in menu.inc

Remaining tasks

User interface changes

API changes

Files: 
CommentFileSizeAuthor
#18 interdiff.txt540 bytesdawehner
#18 local_tasks-2147501.patch21.51 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 59,294 pass(es).
[ View ]
#14 local_tasks-2147501.patch21.62 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 59,218 pass(es).
[ View ]
#14 interdiff.txt1.67 KBdawehner
#13 interdiff.txt3.31 KBdawehner
#13 local_task-2147501.patch23.27 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 59,234 pass(es), 19 fail(s), and 1 exception(s).
[ View ]
#9 local_tasks-2147501.patch20.73 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 59,210 pass(es).
[ View ]
#6 interdiff.txt1005 bytesdawehner
#5 local_tasks-2147501.patch20.01 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 59,107 pass(es), 5 fail(s), and 0 exception(s).
[ View ]
#4 interdiff.txt787 bytesdawehner
#4 local_tasks-2147501.patch19.81 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 59,094 pass(es), 6 fail(s), and 522 exception(s).
[ View ]
#1 local_tasks-2147501.patch19.78 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site.
[ View ]

Comments

dawehner’s picture

Status:Active» Needs review
StatusFileSize
new19.78 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to login to test site.
[ View ]

Here is a patch now.

Status:Needs review» Needs work

The last submitted patch, 1: local_tasks-2147501.patch, failed testing.

aspilicious’s picture

Don't we need a parent_id in the SearchLocalTask local tasks?

dawehner’s picture

Status:Needs work» Needs review
StatusFileSize
new19.81 KB
FAILED: [[SimpleTest]]: [MySQL] 59,094 pass(es), 6 fail(s), and 522 exception(s).
[ View ]
new787 bytes

doh!

dawehner’s picture

StatusFileSize
new20.01 KB
FAILED: [[SimpleTest]]: [MySQL] 59,107 pass(es), 5 fail(s), and 0 exception(s).
[ View ]

Good catch, thank you!

dawehner’s picture

StatusFileSize
new1005 bytes

Forgot the interdiff.

The last submitted patch, 4: local_tasks-2147501.patch, failed testing.

The last submitted patch, 5: local_tasks-2147501.patch, failed testing.

dawehner’s picture

StatusFileSize
new20.73 KB
PASSED: [[SimpleTest]]: [MySQL] 59,210 pass(es).
[ View ]

This time this is green.

tim.plunkett’s picture

#2032309: Use local tasks derivatives to provide local tasks for views would get this even closer.

Do we want to clear up MENU_SIBLING_LOCAL_TASK here too?

dawehner’s picture

Do we want to clear up MENU_SIBLING_LOCAL_TASK here too?

We cannot really here, as I used it in the patch for the admin/help page.

damiankloip’s picture

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.php
@@ -263,6 +263,7 @@ public function submitForm(array &$form, array &$form_state) {
+      \Drupal::cache('cache')->deleteTags(array('local_task' => 1));

This should be TRUE instead of 1. The tag will get casted to a 1 when the tags are flattened, but this should be TRUE. It's just this particular tag storage that does this.

dawehner’s picture

StatusFileSize
new23.27 KB
FAILED: [[SimpleTest]]: [MySQL] 59,234 pass(es), 19 fail(s), and 1 exception(s).
[ View ]
new3.31 KB

Fixed the review of damian.

dawehner’s picture

StatusFileSize
new1.67 KB
new21.62 KB
PASSED: [[SimpleTest]]: [MySQL] 59,218 pass(es).
[ View ]

bla.

damiankloip’s picture

Great, thanks! That looks good now. Will RTBC when green.

note for others regarding #13, we can't do that because we still need to iterate through all cache bins to clear tags.

The last submitted patch, 13: local_task-2147501.patch, failed testing.

amateescu’s picture

+++ b/core/modules/entity/entity.local_tasks.yml
@@ -7,3 +7,18 @@ entity.form_mode_edit:
+entity.view_mode_list:
+  title: List
+  route_name: entity.view_mode_list
+  tab_root_id: entity.view_mode_list
+
+entity.view_mode_list:
+  title: List
+  route_name: entity.view_mode_list
+  tab_root_id: entity.view_mode_list

This looks duplicated.

dawehner’s picture

StatusFileSize
new21.51 KB
PASSED: [[SimpleTest]]: [MySQL] 59,294 pass(es).
[ View ]
new540 bytes

Good catch!

amateescu’s picture

Status:Needs review» Reviewed & tested by the community

Looks good now :)

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Awesome! Glad to see these picked off. From IRC, sounds like we're very close now outside of menu_test.module.

Although this...

+++ b/core/modules/search/lib/Drupal/search/Plugin/Derivative/SearchLocalTask.php
@@ -0,0 +1,42 @@
+/**
+ * Provides local tasks for each search plugin.
+ */
+class SearchLocalTask extends DerivativeBase {
+

Wow, that's quite a mouthful. :\ I guess that's what #2092529: [meta] Improve DX for defining custom routes is attempting to clean up?

In any event...

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.