Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
menu system
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Dec 2013 at 12:22 UTC
Updated:
29 Jul 2014 at 23:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerHere is a patch now.
Comment #3
aspilicious commentedDon't we need a parent_id in the SearchLocalTask local tasks?
Comment #4
dawehnerdoh!
Comment #5
dawehnerGood catch, thank you!
Comment #6
dawehnerForgot the interdiff.
Comment #9
dawehnerThis time this is green.
Comment #10
tim.plunkett#2032309: Use local tasks derivatives to provide local tasks for views would get this even closer.
Do we want to clear up MENU_SIBLING_LOCAL_TASK here too?
Comment #11
dawehnerWe cannot really here, as I used it in the patch for the admin/help page.
Comment #12
damiankloip commentedThis should be TRUE instead of 1. The tag will get casted to a 1 when the tags are flattened, but this should be TRUE. It's just this particular tag storage that does this.
Comment #13
dawehnerFixed the review of damian.
Comment #14
dawehnerbla.
Comment #15
damiankloip commentedGreat, thanks! That looks good now. Will RTBC when green.
note for others regarding #13, we can't do that because we still need to iterate through all cache bins to clear tags.
Comment #17
amateescu commentedThis looks duplicated.
Comment #18
dawehnerGood catch!
Comment #19
amateescu commentedLooks good now :)
Comment #20
webchickAwesome! Glad to see these picked off. From IRC, sounds like we're very close now outside of menu_test.module.
Although this...
Wow, that's quite a mouthful. :\ I guess that's what #2092529: [meta] Improve DX for defining custom routes is attempting to clean up?
In any event...
Committed and pushed to 8.x. Thanks!