I read through your code and think you use exactly the same approach as Apache Solr Multilingual in combination with Apache Solr Config Generator.

Due to the fact that the Apache Solr Search Integration and Search API already joined forces and use the same solr schema, we already discussed to support Search API with the both modules mentioned above.

As you proved with your module, it's doable by just implementing a few "hooks".

As far as I can see "Apache Solr Multilingual" already supports more use cases than "Search API Entity Translation Solr search" (for example term translations) and "Apache Solr Config Generator" is more powerful than your generator.

Therefor I want to invite you to join our project(s) to support both drupal solr solutions. For me this would be a better solution than copying code between our projects. (BTW adding a new sponsor to our projects is not a problem.)

Comments

stefan.r’s picture

stefan.r commented

I like this plan, I will email the maintainer of the Search API Entity Translation Solr search module to check as there have been no commits over the last 8 months and a stable release has yet to come out :)

@mkalkbrenner, what do you need in order to get this going, just a patch to apachesolr_multilingual that makes it support Search API Entity Translation as well?

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Your help is welcome!

I suggest to create a patch against apachesolr_multilingual that adds the required hook implementations.
In a second step we will see how to reduce redundancy in some parts of the code.

Another task is to extend apachesolr_confgen a little bit.

For both modules the hard dependency for apachesolr has to be removed. Instead of that hard dependency we need soft dependencies to apachesolr or search_api modules.

maciej.zgadzaj’s picture

maciej.zgadzaj commented

Thanks guys. I very much support the idea of merging (actually, the main idea, merging or not, would really be to get rid of modules duplicating already existing functionality, which is/might be done better somewhere else).

Also, to be honest, originally this module was written as kind of quick fix/solution for specific client needs, developed to the point that was needed then, and as you have probably noticed, I haven't had any need (not even mentioning time) to take it anywhere further. Therefore if you already have something better, I'd say there is no point in keeping it around.

Just think about a migration path please for all the peeps already using it.

stefan.r’s picture

stefan.r commented
Title: Merge with Apache Solr Multilingual? » Integrate with Search API
Project: Search API Entity Translation Solr search » Apache Solr Multilingual
Status: Active » Fixed

Great news, let's make this happen! :)

OK to mark this as fixed and move integration discussion to #2291657: Integrate with Search API Entity Translation?

stefan.r’s picture

stefan.r commented
Title: Integrate with Search API » Merge with Apache Solr Multilingual?
stefan.r’s picture

stefan.r commented
Project: Apache Solr Multilingual » Search API Entity Translation Solr search

Had accidently changed these, reverting

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.