The Media module currently contains a number of variables which actually belong to its submodules. These variables should be moved to their respective submodules for consistency, performance and code readability.

CommentFileSizeAuthor
#1 migrate-submodule-variables-2147221-1.patch13.05 KBDevin Carlson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review
FileSize
migrate-submodule-variables-2147221-1.patch13.05 KB

A patch which adds an update function to move variables to submodules as appropriate, implements hook_uninstall() in all relevant submodules to remove the variables on uninstall and accommodates the minor changes caused by the variable shuffle.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Needs review » Fixed

Tested #1 a fresh Media install with all submodules enabled to verify that nothing was broken and on an existing Media install to verify that the update function successfully migrated each of the variables.

Committed #1 to Media 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.