Preventing subscription until eCheck clears? [#214670]

Is there a way to prevent subscriptions paid by eCheck from going active until after the echeck clears?
Currently if someone pays for a subscription via echeck, LM_Paypal activates the subscription immediately instead of waiting for the echeck to clear..

Comment	File	Size	Author
#2	lm_paypal_subscriptions_escalate_on_paid.patch	2.55 KB	mrtoner

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mrtoner CreditAttribution: mrtoner commented 27 January 2008 at 08:22

Assigned:

Unassigned

» mrtoner

I noticed that when looking at the code last night. Although lm_paypal ignores pending payments, it accepts a subscription creation as reason to assign the role/group/node. I understand the reason for this: a free trial won't generate a payment for the trial period, so the assignation must happen during subscription creation.

To keep non-free subscription signups from going active when the payment is pending, it should be possible to test the IPN variable amount1 and only activate for a value of '0' (free trial). All other signups will only activate upon payment completion. I'll write a patch and upload it tomorrow.

Comment #2

mrtoner CreditAttribution: mrtoner commented 29 January 2008 at 17:36

Category:	support	» bug
Status:	Active	» Needs review

File	Size
lm_paypal_subscriptions_escalate_on_paid.patch	2.55 KB

Okay, this patch changes the behavior of a subscription signup. A transaction of "subscr_signup" will only escalate a role/group if the signup has a free trial. For all other signups, the role/group escalation will occur when the payment is completed.

YMMV. Please test fully.