In components/markup.inc there is a TODO to remove the line where $element['#value'] is set to $element['#markup']

I think that this can now be done.

CommentFileSizeAuthor
#1 webform_remove_extra_line-2146665-1.patch427 bytesmalcomio

Comments

malcomio’s picture

malcomio commented
Status: Active » Needs review
StatusFileSize
new webform_remove_extra_line-2146665-1.patch427 bytes

Here's a patch that does it

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Ha! I can't believe that's still in there. That must've been from the original Drupal 7 port. Thanks. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 7.x-4.x-dev » 8.x-4.x-dev
Assigned: malcomio » fenstrat
Status: Closed (fixed) » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Version: 8.x-4.x-dev » 7.x-4.x-dev
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed 9c76f30 to 8.x-4.x. Thanks!

  • Commit 64f6ca6 on 8.x-4.x authored by malcomio, committed by fenstrat: 
    Issue #2146665 by malcomio: Remove #value from markup component.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.