When viewing a page with a cached panel pane a PHP warning is shown for an undefined index.

Attached patch checks for existence of array element before testing value of element.

CommentFileSizeAuthor
#13 panels_content_cache-n2145609-13.patch420 bytesdamienmckenna
#10 panels_content_cache-n2145609-10.patch537 byteslegovaer
#6 panels_content_cache-n2145609-5.patch2.6 KBdamienmckenna
#3 panels_content_cache-n2145609-3.patch2.2 KBdamienmckenna
panels_content_cache-fix-php-warning-1.patch503 bytesjaydub

Comments

Exploratus’s picture

Exploratus commented

Thanks! That fixed my error!

Notice: Undefined index: content_types in panels_content_cache_settings_form() (line 134

We should get this commited!

Exploratus’s picture

Exploratus commented

Nevermind. Still have the error

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panels_content_cache-n2145609-3.patch2.2 KB

Rerolled and also updated to resolve similar errors on the same file.

Status: Needs review » Needs work

The last submitted patch, 3: panels_content_cache-n2145609-3.patch, failed testing.

The last submitted patch, 3: panels_content_cache-n2145609-3.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new panels_content_cache-n2145609-5.patch2.6 KB

Doh! Sorry about that. This one will work.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

This needs to be backported to D6, it has many of the same code glitches.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Needs work

A part of the issue is solved. Found another notice warning as soon as the user tries to save a node.

Notice: Trying to get property of non-object in panels_content_cache_get_base_cid() (line 228 of /www/dev-drupal/modules/contrib/panels_content_cache/plugins/cache/content.inc).

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs work » Needs review
StatusFileSize
new panels_content_cache-n2145609-10.patch537 bytes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Needs review
StatusFileSize
new panels_content_cache-n2145609-13.patch420 bytes

As reported by someone at Acquia.

  • DamienMcKenna committed 7814d8f on 7.x-1.x authored by ss81 
    Issue #2145609 by ss81: Another "undefined" variable warning.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed, back to D6 again.