We can now remove this and drupal_set_breadcrumb..

CommentFileSizeAuthor
#3 2145463-3.patch2.05 KBjibran
d8.remove-legacy-crumb.patch2.78 KBdamiankloip

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community
Parent issue: » #2061913: Remove drupal_set_breadcrumb and LegacyBreadcrumbBuilder in Views module

The original issue was a critical.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Related issues: +#2026075: [meta] Remove drupal_set_breadcrumb and LegacyBreadcrumbBuilder

IMHO it should happen in #2026075: [meta] Remove drupal_set_breadcrumb and LegacyBreadcrumbBuilder but I am fine with it. Now dsb is finally gone. Thanks @damiankloip in completing this. Yay!!!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2145463-3.patch2.05 KB

Here is the updated patch.

damiankloip’s picture

damiankloip commented

Why do we need that patch? That's the same as the rtbc patch but doesn't remove the service definition. As far as I can tell, the patch in the summary is the one we want. Or am I missing something here?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Sorry for the inconvenience #0 is fine and RTBC. Please ignore my patch

damiankloip’s picture

damiankloip commented

Ha :-) OK.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2145463-3.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Reviewed & tested by the community

Back to rtbx for #0. Let's forget about the last patch :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Awesome! Glad to see some of these old BC layers finally biting the dust.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.