Comments

pwolanin’s picture

We need to follow-up to the local task/action plugins change to potentially make the breadcrumb service aware of these plugins and add those paths to the end of the breadcrumb.

andypost’s picture

So maybe better to file per-module issue to fix breadcrumbs and local tasks same time?

andypost’s picture

there's only 13 left for drupal_set_breadcrumb()

:~/www/core8# git grep drupal_set_breadcrumb
core/includes/common.inc:function drupal_set_breadcrumb($breadcrumb = NULL) {
core/includes/menu.inc: * Additionally, breadcrumbs set by drupal_set_breadcrumb() will override any
core/modules/comment/comment.pages.inc:  drupal_set_breadcrumb(array(l(t('Home'), NULL), l($node->label(), 'node/' . $node->id())));
core/modules/menu_link/lib/Drupal/menu_link/MenuLinkFormController.php:      drupal_set_breadcrumb($breadcrumb);
core/modules/system/lib/Drupal/system/LegacyBreadcrumbBuilder.php: * drupal_set_breadcrumb() mechanic.
core/modules/system/lib/Drupal/system/LegacyBreadcrumbBuilder.php: * Remove this once drupal_set_breadcrumb() has been eliminated.
core/modules/system/lib/Drupal/system/LegacyBreadcrumbBuilder.php:    $breadcrumb = drupal_set_breadcrumb();
core/modules/system/system.api.php: * of setting a custom breadcrumb via drupal_set_breadcrumb().
core/modules/system/system.api.php: * @see drupal_set_breadcrumb()
core/modules/taxonomy/taxonomy.pages.inc:  drupal_set_breadcrumb($breadcrumb);
core/modules/views/lib/Drupal/views/ViewExecutable.php:   *   If true, use drupal_set_breadcrumb() to install the breadcrumb.
core/modules/views/lib/Drupal/views/ViewExecutable.php:        if ($base && $current_breadcrumbs = drupal_set_breadcrumb()) {
core/modules/views/lib/Drupal/views/ViewExecutable.php:        drupal_set_breadcrumb($breadcrumb);
AndreyMaximov’s picture

Assigned: Unassigned » AndreyMaximov
Issue tags: +CodeSprintCIS
larowlan’s picture

larowlan’s picture

Issue summary: View changes

Added links to child issues

jibran’s picture

Issue summary: View changes

Updated remaining tasks.

andypost’s picture

Issue summary: View changes
Status: Active » Closed (duplicate)
Related issues: +#2061937: Remove drupal_set_breadcrumb and LegacyBreadcrumbBuilder in includes

Suppose better close this one because last issue marked as Critical #2061913: Remove drupal_set_breadcrumb and LegacyBreadcrumbBuilder in Views module