For multiple subqueue handlers it would be nice to be able to delete subqueues. The patch in #33 on #1450590: Add permissions to queues already includes the permissions for this action, now we just need a delete link and confirmation form.

CommentFileSizeAuthor
#1 entityqueue-subqueue-delete-2145457-1.patch7.01 KBjojonaloha

Comments

jojonaloha’s picture

jojonaloha commented
Status: Active » Needs review
Related issues: +#1450590: Add permissions to queues
StatusFileSize
new entityqueue-subqueue-delete-2145457-1.patch7.01 KB

This patch actual requires that the patch in #33 of #1450590: Add permissions to queues is applied first. It adds a 'delete subqueue' link to the operations on the subqueues page. It also adds a canDeleteSubqueue(EntitySubqueue $subqueue) to EntityQueueHandlerInterface. For the MultipleEntityQueueHandler it doesn't allow deleting the original subqueue.

amateescu’s picture

amateescu commented

The patch looks good, feel free to commit it.

I did notice a slightly weird behavior while testing it though, something that I didn't anticipate in the original code that added the 'multiple queues' handler. Why do we default to create an initial subqueue for that case? It seems that if people want multiple subqueues, they should also be allowed to control the name of the first subqueue and also delete it. Maybe open a followup issue for that? It will also affect the canDeleteSubqueue() code introduced here..

jojonaloha’s picture

jojonaloha commented
Version: » 7.x-1.x-dev
Status: Needs review » Fixed

Committed 76425b7

Also opened a follow-up issue: #2156879: Don't add initial subqueue for multiple queues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.