Like most distros, we use patches as a stopgap measure when it tests successfully for us, but either hasn't been RTBC'd into a module or is fixed but not into the next release. Below is a list of modules with their patches that need work.

I suggest we look back at these patches and start contacting maintainers to get new releases out with them if they're RTBC, and if not, figure out what is wrong and get a release out. The more patches we need to apply, the more complicated the build gets, and it can potentially lead to a race condition where one patch invalidates another.

Drupal Core: 3 patches exist:
#1971072: Install profiles cannot list their own requirements in drupal_check_profile -- needs review, RTBC for 8.x before being backported to 7.x
#1772316: Allow install profiles to change the system requirements -- needs review, RTBC for 8.x, before being backported to 7.x
#1664602: Allow attributes to be passed to drupal_add_[css|js] (SRI) -- needs work on 7.x, Fixed for 8.x

Comments

lsolesen’s picture

lsolesen commented

@japerry Is there any work left to be done here?

japerry’s picture

japerry
Location KOMK
commented
Priority: Major » Minor

Bumping down to minor, as we're keeping track of these patches in the make file. Any of the issues that aren't closed could potentially get committed upstream, but there could be several blockers.

Basically as issues are solved and versions of modules increment, we remove the patches because they will otherwise fail testing when rebuilding commons.