Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I've tracked it down to this issue:
#487518: Tab selection fails on IE7
When you have a hidden tab then the Drupal.settings.quicktabs['qt_page'].tabs array does not have consecutive numbers, therefore the array in JS turns into an object
Drupal.settings.quicktabs['qt_page'].tabs
Object {0: Object, 3: Object}
0: Object
3: Object
__proto__: Object
Drupal.settings.quicktabs['qt_page'].tabs.length doesn't work on an object, resulting in that you cannot switch tabs anymore when tabs are hidden. Reverting this commit fixes the issue for me:
http://drupalcode.org/project/quicktabs.git/blobdiff/68a4131d70663346405...
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2104643-revert-qt-487518-5.patch | 833 bytes | japerry |
Comments
Comment #1
Jovean CreditAttribution: Jovean commentedI can confirm both the bug and the solution.
Comment #2
stefan.kornI can confirm bug and solution too.
Comment #3
glynster CreditAttribution: glynster commentedConfirmed fixes the problem for me too.
Comment #4
W01F CreditAttribution: W01F commentedConfirmed, thank goodness...
Comment #5
japerrySilly IE7 users. ;-)
Here is the revert patched.
Comment #6
stefan.kornYes, that fixes the problem.
But this was not affecting only IE7 users, but all browsers I think. As explained by Johnny vd Laar in issue summary it is a general javascript error in the code.
Comment #7
glynster CreditAttribution: glynster commentedPerfect let's get this committed please.
Comment #8
mngates CreditAttribution: mngates commentedConfirmed that it was affecting Firefox and other browsers (not just IE) and the fix worked great for my sites. Please commit when possible. Thank you to all who helped!
Comment #9
japerryI've just reopened: #487518: Tab selection fails on IE7
The revert should probably be applied soon (since its broken in other browsers right now), and the fix worked on there.
Comment #10
wickwood CreditAttribution: wickwood commentedI was experiencing this problem in Mac Google Chrome and Safari and clients first reported it who were using IE9 and Windows FireFox. So it is definitely not an IE& specific problem.
Patch from #5 also fixed things for me.
Thanks for the patch!
Comment #11
tripper54 CreditAttribution: tripper54 commented7.x-3.6 broke my sites. This thread correctly identified the reason and the fix.
+1 for getting this committed ASAP.
Comment #12
illeace CreditAttribution: illeace commentedThanks for the bug write-up and patch. An unpublished page in one of my quicktabs was causing this problem for me.
Comment #12.0
illeace CreditAttribution: illeace commentedMake a link of issue nr.
Comment #13
marc.groth CreditAttribution: marc.groth commentedAs with everybody else, reverting the quicktabs.js file to what it was for 7.x-3.4 (which is effectively what the patch does) works and fixes the issue.
Comment #14
drupal_jon CreditAttribution: drupal_jon commentedThe patch (or rolling back the quicktabs.js file as Marc said) works for me.
Looks like we need a new release as 7.x-3.6 is broken for common use cases?
Comment #15
ultimateboy CreditAttribution: ultimateboy commentedThe exact same patch provided in #5 was also provided in #2108935: Tab switching doesn't work in quicktabs 3.6 if hidden tabpages that creates gaps in the numbering of tabs which was just committed to 7.x-3.x.
Thanks all.