Show default image on image field

Contrib: https://www.drupal.org/project/image_widget_default_image

Better title

Fix tests + additional tests.

Replaced entity_load() calls with File::load().

I was about to mark this RTBC (because the above doesn't count), but then something in the behavior threw me a bit off: The default image is displayed to the right of the upload form element, but when an image has been uploaded that is displayed to the left of the form element. (See the attached screenshots, also.) Is that intended?

Oops, here are the mentioned screenshots.

Ha, hmm interesting. That's a bit weird indeed.
I'm also wondering whether we should add some guiding text to tell the user that this is a default image ?

Hmm.. good question. I would say "Yes" but I can't really imagine how that would look. I already find the file name and size to be rather distracting, TBH.

So it's just a matter of adding a weight to align it to the left.
(-10 is my lucky number)

Moved the upload image to the left as well, makes much sense!

Cancelled both tests for this patch - small change in comment of test.

ifrik - feel free to RTBC, we'll see what the core committers think :)

I've asked on IRC for wither yoroy or Bojhan to have a look at this wrt to usability.

I think I'm missing something. Simply-testing the patch in #17 doesn't give me an altered image field on the core Article content type. And does the screenshot in #17 even show the default image?

Status

Yoroy: you need to upload a default image on the image field, so manage fields > article > image
Then go to node/add/article, you should see the image there.

Duh! This perpetual noob always expects the CMS to do things automatically :-)

Anyway, the general idea is sound. It makes sense to show a default image on the form when there is one defined.

## Before with a default image defined, no upload

## Before, with a default image defined, with upload

## After, with a default image defined, no upload

## After, with a default image defined, with upload

The only thing that looks strange to me is the file link info put after the alt text. This whole widget still looks wonky overall, and most of this patch improves things already quite a bit but lets keep the thumbnail and the file name/link together:

Played with the weights and this was the easiest way to ge a more consistent view. Alt and title are above, just like they used to be, image is on the left.
If this is ok, we can look for follow ups, because the remove button is being a bit annoying here to position right.

Thanks for the updated patch. Seems to me that this issue achieves its intended goal so back to RTBC

#2115469: Image Field style update has the plan for an updated image field styling.

Thanks @yoroy - remembered to add you the commit credit - usability reviews definitely deserve at least that :)

Committed f070288 and pushed to 8.0.x. Thanks!