Updated: Comment #N

Problem/Motivation

Spawned from related issue, cache factories do not implement a common interface, which could make switching things out more fragile

Proposed resolution

Add a CacheFactoryInterface and have our factories implement this.

Remaining tasks

User interface changes

None

API changes

Factories should implement this interface.

CommentFileSizeAuthor
#8 interdiff-2143011-8.txt531 bytesdamiankloip
#8 2143011-8.patch2.5 KBdamiankloip
#2 interdiff-2143011-2.txt999 bytesdamiankloip
#2 2143011-2.patch1.98 KBdamiankloip
d8.cacheFactoryInterface.patch2.05 KBdamiankloip

Comments

Status: Needs review » Needs work

The last submitted patch, d8.cacheFactoryInterface.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 2143011-2.patch1.98 KB
new interdiff-2143011-2.txt999 bytes

Should be implemented for DatabaseBackend and MemoryBackend.

The last submitted patch, 2: 2143011-2.patch, failed testing.

damiankloip’s picture

damiankloip commented

2: 2143011-2.patch queued for re-testing.

The last submitted patch, 2: 2143011-2.patch, failed testing.

damiankloip’s picture

damiankloip commented

2: 2143011-2.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Related issues: +#2156265: KeyValueFactory is swappable, add an interface and fix type-hints
damiankloip’s picture

damiankloip commented
StatusFileSize
new 2143011-8.patch2.5 KB
new interdiff-2143011-8.txt531 bytes

Ok, speaking to berdir about this, and seeing the referenced key value issue about. Let's use the interface for the CacheFactory class too.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
xjm’s picture

xjm
she/her
Primary language English
commented

8: 2143011-8.patch queued for re-testing.

damiankloip’s picture

damiankloip commented

8: 2143011-8.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.