The installer contains a smart hack to temporarily override $settings to use the KeyValueMemoryFactory instead of the default database factory implementation.

This override and temporary adjustment (and rollback) of $settings can be avoided by registering the KeyValueMemoryFactory directly in the service container.

Doing so reveals that the KeyValueFactory service is swappable, but some other services are using type-hints that explicitly ask for the default implementation. Hence, we need to add an interface for the factory service.

CommentFileSizeAuthor
drupal8.keyvaluefactoryinterface.0.patch11.56 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Parent issue: » #2155701: Installer starts with fatal error/exception "table 'semaphore' not found" if settings.php contains $databases already
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Seems simple enough so RTBC.

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 rtbc here

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Normal » Major

This fix blocks #2155701: Installer starts with fatal error/exception "table 'semaphore' not found" if settings.php contains $databases already

(merging this patch into that patch fixes all test failures)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Nice clean-up. Committed to 8.x.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

This uses the same interface for the expirable key value store, that returns a different interface. See #2160495: Add a KeyValueExpirableFactoryInterface.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.