This is a very simple change; I hoped we can get rid of the whole of Doctrine Commons but as we use Reflection, we can't alas. Still, for easier review, attached is the composer.json change separately. The patch contains the results of composer update doctrine/annotations.

The relevant grammar was:

Annotation     ::= "@" AnnotationName ["(" [Values] ")"]
Values ::= Array | Value {"," Value}*

Now we have

Annotation     ::= "@" AnnotationName MethodCall
MethodCall ::= ["(" [Values] ")"]
Values ::= Array | Value {"," Value}* [","]
Files: 
CommentFileSizeAuthor
#6 2138867_4.patch41.59 KBchx
PASSED: [[SimpleTest]]: [MySQL] 59,045 pass(es).
[ View ]
#4 trailing_commas_review.txt428 byteschx

Comments

tim.plunkett’s picture

Status:Active» Reviewed & tested by the community
Issue tags:+Plugin system

For those following along, this is a result of https://github.com/doctrine/annotations/pull/11

I say +1 to this, if we want the rest of doctrine back later we can add it in, that's the beauty of composer.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, trailing_commas.patch, failed testing.

chx’s picture

Issue summary:View changes
chx’s picture

Issue summary:View changes
StatusFileSize
new428 bytes
new74.41 KB
PASSED: [[SimpleTest]]: [MySQL] 59,007 pass(es).
[ View ]
tim.plunkett’s picture

Status:Needs work» Needs review

A little less hasty with my RTBC this time, if this passes I'll be back for it.

chx’s picture

Issue summary:View changes
StatusFileSize
new41.59 KB
PASSED: [[SimpleTest]]: [MySQL] 59,045 pass(es).
[ View ]

timplunkett tells me not to upgrade Doctrine Commons itself. Sure.

chx’s picture

Issue summary:View changes
tim.plunkett’s picture

Status:Needs review» Reviewed & tested by the community

Annnnddddd passing.

webchick’s picture

Status:Reviewed & tested by the community» Fixed

One of my top, like, 6 patches of all time. :)

Committed and pushed to 8.x. YEAH!

webchick’s picture

Retroactively tagging.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.