Since after the last callback convewrsion (#2039277: Convert aggregator/opml to the new controller style.) .pages.inc will be mostly theme functions. so let put them in .theme.inc and remove .pages.inc in the long run (not here)

CommentFileSizeAuthor
#11 split-aggregator-theme-2138115-11.patch15.19 KBInternetDevels
#11 interdiff-2138115-9-11.txt452 bytesInternetDevels
#9 split-aggeregator-theme-2138115-9.patch15.12 KBInternetDevels
#4 drupal-aggregator-2138115-4.patch11.89 KBParisLiakos
#1 drupal-aggregator-2138115.patch12.75 KBParisLiakos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Needs review
FileSize
drupal-aggregator-2138115.patch12.75 KB
ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: drupal-aggregator-2138115.patch, failed testing.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Title: Split aggregator theme functions to a seperated file » Split aggregator theme functions to a seperate file
Status: Needs work » Needs review
FileSize
drupal-aggregator-2138115-4.patch11.89 KB
ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Issue tags: +Needs reroll
ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Needs work
adixb’s picture

adixb CreditAttribution: adixb commented
Assigned: Unassigned » adixb
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

@adambehnke: We lost you on IRC so leaving a comment here.

I suggest the best way forward is just to recreate the patch from scratch instead of trying to reroll and resolve conflicts. Since the task is just to move functions from one file to another we can do this with the code in HEAD and create a fresh patch.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
FileSize
split-aggeregator-theme-2138115-9.patch15.12 KB

Created a fresh patch.

Status: Needs review » Needs work

The last submitted patch, 9: split-aggeregator-theme-2138115-9.patch, failed testing.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
FileSize
interdiff-2138115-9-11.txt452 bytes
split-aggregator-theme-2138115-11.patch15.19 KB

Added file parameter to aggregator_block_item.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

thanks you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: Split aggregator theme functions to a seperate file » Split aggregator theme functions to a separate file
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs reroll

Committed edd8fd8 and pushed to 8.x. Thanks!

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented

thanks!
followup to get rid of .pages.inc now:)
#2195779: Remove aggregator_load_feed_items()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.