Lots of small coding standards changes like:

  1. Add missing @file docblocks.
  2. Update/correct the closures in JS files to reflect the actual dependencies of the JS in that file.
  3. Removed the last reference to Create.js.
  4. Apply {@inheritdoc} where it's not yet being used.
  5. s/function/public function/ where that is not yet set
  6. Remove the @todo in MockEditEntityFieldAccessCheck.php to remove that mocked class when a certain issue has landed, because until tests are converted to use PHPUnit rather than DrupalUnitTestBase, we will continue to need that mocked class, since we can't simulate request data in DUTB.

In other words: fix lots of small nitpicks that have been accumulated over time.

CommentFileSizeAuthor
#7 2135689-7.patch21.91 KBwim leers
#4 2135689-4.patch24.08 KBwim leers
#2 2135689-2.patch24.09 KBwim leers

Comments

wim leers’s picture

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new24.09 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2135689-2.patch, failed testing.

wim leers’s picture

Status: Needs work » Needs review
StatusFileSize
new24.08 KB

I accidentally rolled this patch against a modified HEAD.

wim leers’s picture

Status: Needs review » Postponed

And in fact, it's still against a modified HEAD now, but an intentional one. This should go in after #2134929: Clean up Edit: rename EntityView to EntityDecorationView.

wim leers’s picture

Status: Postponed » Needs review
wim leers’s picture

StatusFileSize
new21.91 KB

Now that blockers have been committed, reroll against HEAD!

Status: Needs review » Needs work

The last submitted patch, 7: 2135689-7.patch, failed testing.

wim leers’s picture

Status: Needs work » Needs review

7: 2135689-7.patch queued for re-testing.

jessebeach’s picture

Status: Needs review » Reviewed & tested by the community

This patch contains comments, whitespace and test method declaration changes (adding public). There are no behavior changes.

I jshinted the files. There are not exceptions or warnings.

I manually tested the Edit in place feature and found now behavior regressions.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

wim leers’s picture

Issue tags: -sprint
wim leers’s picture

Now also backported to the Drupal 7 contrib module: http://drupalcode.org/project/edit.git/commit/5e519a6.

nod_’s picture

Issue tags: +JavaScript

tag

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.