Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
edit.module
Priority:
Minor
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
14 Nov 2013 at 11:09 UTC
Updated:
29 Jul 2014 at 23:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
wim leersComment #2
wim leersComment #4
wim leersI accidentally rolled this patch against a modified HEAD.
Comment #5
wim leersAnd in fact, it's still against a modified HEAD now, but an intentional one. This should go in after #2134929: Clean up Edit: rename EntityView to EntityDecorationView.
Comment #6
wim leers#2134929: Clean up Edit: rename EntityView to EntityDecorationView landed, now this one can go in.
Comment #7
wim leersNow that blockers have been committed, reroll against HEAD!
Comment #9
wim leers7: 2135689-7.patch queued for re-testing.
Comment #10
jessebeach commentedThis patch contains comments, whitespace and test method declaration changes (adding
public). There are no behavior changes.I jshinted the files. There are not exceptions or warnings.
I manually tested the Edit in place feature and found now behavior regressions.
Comment #11
webchickCommitted and pushed to 8.x. Thanks!
Comment #12
wim leersComment #13
wim leersNow also backported to the Drupal 7 contrib module: http://drupalcode.org/project/edit.git/commit/5e519a6.
Comment #14
nod_tag