While working on #1457256: Enable Lite Pager On Project Issues Advanced Search I discovered a bug in search_api_views regarding how the pager is handled. Turns out that in SearchApiViewsQuery::execute(), we're invoking the pager plugin's post_execute() method with am empty array. This causes the pager plugins to get confused about if there's another page of results to display or not, and therefore if the pager should appear at all.

Trivial patch coming soon.

CommentFileSizeAuthor
#1 2135255-1.search_api_views_no_pager_on_page_0.patch584 bytesdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 2135255-1.search_api_views_no_pager_on_page_0.patch584 bytes

It's just a simple typo in the invocation, confusion over result vs. results.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Ah, damn, another sloppy patch review coming back to haunt me …
Thanks a lot for spotting and fixing this! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.