@see directives should not have a line length limit imposed on them since valid URLs can easily put a line over the 80 character limit and it doesn't make sense to wrap a URL. (The same would be true of crazy long, namespaced class references, though that's doubtless a less common scenario.)

CommentFileSizeAuthor
#5 coder.coder_sniffer.2135201.5.patch1.23 KBtraviscarden
#1 coder.coder_sniffer.2135201.1.patch728 bytestraviscarden

Comments

traviscarden’s picture

traviscarden commented
Status: Active » Needs review
StatusFileSize
new coder.coder_sniffer.2135201.1.patch728 bytes

Here's a patch to get started with. It doesn't include any changes or additions to the test files or anything. Note that the regex I used will match an @see directive in a docblock or a standard // comment--which I'm pretty sure is a valid scenario--unlike the test for @link directives right above it.

grasmash’s picture

grasmash commented
Status: Needs review » Reviewed & tested by the community

I've tested this patch and can confirm that it works as intended. I support the change.

traviscarden’s picture

traviscarden commented
Related issues: +#2145799: Don't impose line length limit on @code..@endcode blocks
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Needs work

Looks reasonable, can we have a test case comment in Test/good.php to verify this works?

traviscarden’s picture

traviscarden commented
Status: Needs work » Needs review
StatusFileSize
new coder.coder_sniffer.2135201.5.patch1.23 KB

Sure!

grasmash’s picture

grasmash commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks! http://drupalcode.org/project/coder.git/commit/d775489

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.