Part of #1989974: [meta] Clean up/improve consistency of Edit.

Rationale:

  • This is not a view of the entity itself, it's a view that decorates the existing entity on the page: it does not render anything, it only decorates something.
  • This is not an API change.
CommentFileSizeAuthor
#2 interdiff.txt748 bytesWim Leers
#2 2134929-2.patch4.64 KBWim Leers
#1 2134929-1.patch2.93 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Active » Needs review
FileSize
2134929-1.patch2.93 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
FileSize
2134929-2.patch4.64 KB
interdiff.txt748 bytes
jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Needs review » Reviewed & tested by the community

I reviewed and manually tested this code. It does not introduce any new behaviors or regressions.

Renaming EntityView to EntityDecorationView makes sense in this case. This View is not rendering the entity in HTML, it's adding qualities to existing HTML.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

2: 2134929-2.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Seems fine, and brings consistency to the code base. I can't imagine this would break any contrib modules that were already porting to D8.

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.