The file with function definition is not included. The patch fixes this.

CommentFileSizeAuthor
#8 rules-include_user_rules_inc-8.patch535 bytescafuego
rules-include_user_rules_inc.patch532 bytesmaximpodorov

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented

Awesome! Just needs tests

lklimek’s picture

lklimek commented

This patch solves the issue for me. Thanks! :)

maximpodorov’s picture

maximpodorov commented

@andypost, why do you think this trivial patch requires testing?

drupov’s picture

drupov commented

Patch works against 2.6

sbrattla’s picture

sbrattla commented

Why is this patch stuck?

It solves the issue for on 2.6.

maximpodorov’s picture

maximpodorov commented

If you think patch works, you can set this issue status to "Reviewed & tested by the community".

sbrattla’s picture

sbrattla commented
Status: Needs review » Reviewed & tested by the community

I believe this one is RTBC based on both others and my own testing.

cafuego’s picture

cafuego commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new rules-include_user_rules_inc-8.patch535 bytes

Moved the call to module_load_include() to inside the first if() statement, so the code will run a bit more efficiently and will not load the included file if no email is going to be sent anyway.

Updated patch (definitely passes local testing) attached.

maximpodorov’s picture

maximpodorov commented
Status: Needs review » Reviewed & tested by the community

The patches are functionally equivalent. So the maintainers can choose any one.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

joshuautley’s picture

joshuautley commented

Worked for my issue as well. Thank you!

jsibley’s picture

jsibley commented

This works for me. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.