Minor UI issue.

On the track page, the large number of pager items means that these start wrapping once you get up to page 15 or so. This would be much worse if this page had a sidebar.

Dries tracker, nearing the end.

Hyper-theoretical 1000+ pager.

I'd suggest halving the number of items and to consistently apply these settings to all pagers within the main content region on the site. For example the project issue pages are limited to 9 items:

Cores issue queue, nearing the end. Only 9 items but would just fit with a sidebar.

To replicate, page to about page 20 in your issue tracker, or try Wim's https://drupal.org/user/99777/track?page=24

CommentFileSizeAuthor
#14 drupal-2130461-14-tracker-pager-default-quantity-in-sync-with-core.patch413 bytesalan d.
#9 drupal-2130461-9-tracker-pager-default-quantity-in-sync-with-core.patch413 bytesalan d.
#1 pager-issue-1000.png6.51 KBalan d.
#1 pager-track-1000.png6.52 KBalan d.
#1 pager-track-400.png5.5 KBalan d.
project-issues-pager.png9.42 KBalan d.
track-posts-pager-wrapping.png7.46 KBalan d.

Comments

alan d.’s picture

alan d. commented
Issue summary: View changes
StatusFileSize
new pager-track-400.png5.5 KB
new pager-track-1000.png6.52 KB
new pager-issue-1000.png6.51 KB

Added additional images to show difference pager numbers with real examples.

eliza411’s picture

eliza411 commented
Issue tags: +D.o UX

It's worth a double-check with folks that the {n} visible items is enough, but what you're proposing makes sense to me fwiw

Tagging

tvn’s picture

tvn commented
Status: Needs review » Active

Consistency will be good. We'll need to bring the pager on issue queues back first.

alan d.’s picture

alan d. commented
Status: Active » Needs review

Strange workflow here, this state flags it to the team to decide if it needs fixing and then they push it to the right area.

Although I hope the other issues are looked at first, this is so totally minor ;)

alan d.’s picture

alan d. commented
Status: Needs review » Active

Sorry, I thought this would have changed queues rather than being just tagged.

jthorson’s picture

jthorson commented

https://drupal.org/comment/8234805#comment-8234805 proposes changing this to a view, which has the pager restricted to 9 items.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +pagers
Related issues: +#2135385: Regression: the pager no longer lets me jump to pages, nor shows total number of pages, +#2130537: user/%/track not sorting correctly

Still an issue. Is this also a problem with Core? I agree moving this to a View would fix the problem, but why is it a problem?

drumm’s picture

drumm
he/him
Location NY, US
commented

Yep, this is core modules/tracker/tracker.pages.inc:

  $page['pager'] = array(
    '#theme' => 'pager',
    '#quantity' => 25,
    '#weight' => 10,
  );

The next step is to see if there is a good reason for it to be that way in core, and the likelihood of it changing in D7. It seems arbitrary, but maybe there is a good reason.

(If changing in core is a no-go, then we should be able to alter that render array in drupalorg.)

alan d.’s picture

alan d. commented
Title: Pager wrapping on user/%/track » Tracker pager is inconsistent with every other pager in core
Project: [Archive] Drupal.org D7 upgrade QA » Drupal core
Version: » 8.x-dev
Component: User interface » tracker.module
StatusFileSize
new drupal-2130461-9-tracker-pager-default-quantity-in-sync-with-core.patch413 bytes

Very strange, moving to core to see if anyone knows why. Every other pager in D7 core uses the default value that is 9. :/

In D8, the views module also appears to differ slightly from the default albeit I am not sure if these settings are actually overridden with 9 in practice (grep of the code base for 'quantity'):

  // Our extra version of pager from pager.inc
  $hooks['views_mini_pager'] = $base + array(
    'variables' => array('tags' => array(), 'quantity' => 10, 'element' => 0, 'parameters' => array()),
    'template' => 'views-mini-pager',
  );

  $variables = array(
....
    'pager' => array(
      'view' => NULL, 'options' => NULL,
      'tags' => array(), 'quantity' => 10, 'element' => 0, 'parameters' => array()
    ),
  );

Quick scan didn't reveal any more inconsistencies with the quantity.

alan d.’s picture

alan d. commented
Status: Active » Needs review
jthorson’s picture

jthorson commented
Status: Needs review » Reviewed & tested by the community

Okay ... RTBC for D8. We'll see if we can backport it to D7, and if not, then will bounce back to an alter in drupal.org.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs backport to D7

Oh, interesting. Nice catch. I can't think of a good reason for this either and it *seems* backportable, since it's not likely to break anyone's code.

Committed and pushed to 8.x, marking to 7.x for backport.

  • Commit f923acd on 8.x by webchick: 
    Issue #2130461 by Alan D.: Tracker pager is inconsistent with every...
alan d.’s picture

alan d. commented
Status: Patch (to be ported) » Needs review
Issue tags: -Needs backport to D7
StatusFileSize
new drupal-2130461-14-tracker-pager-default-quantity-in-sync-with-core.patch413 bytes
alan d.’s picture

alan d. commented
Issue tags: +Needs backport to D7
drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: +affects drupal.org
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: drupal-2130461-14-tracker-pager-default-quantity-in-sync-with-core.patch, failed testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Needs review

14: drupal-2130461-14-tracker-pager-default-quantity-in-sync-with-core.patch queued for re-testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +7.28 release notes

Committed to 7.x - thanks!

  • Commit 972e6a9 on 7.x by David_Rothstein: 
    Issue #2130461 by Alan D.: Tracker pager is inconsistent with every...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.