Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I assume that d.org is using Flag 3.x for the follow links?
Are there any issues that should be considered?
Flag has a few open issues to do with deletion of field data and proper integration with entity CRUD hooks. However, I've been concerned about the scaling issues that would go with causing a big chain reaction of entity deletion when flagged entities or users are deleted. If d.org is using Flag 3.x, I should probably take a closer look at the workflows that d.org is using and check they're ok.
Deployment
- Update flag to
357d41dfor #2488122: Error on update from 7.x-2.x to 7.x-3.x (update 7303) - Update flag_tracker to 2.0-beta1, see #2224729: Flag 7.x-3.x branch support
- Update project_issue to
53acdf5or newer, see #2594205: Update for flag 3.x - Merge & deploy
2125851-flag-3in drupalorg - Deploy with updatedb & cc all
Comments
Comment #1
eliza411 commentedDrupal.org is using Flag 7.x-2.1.
Comment #2
joachim commentedInteresting choice...
It's not the recommended 7.x branch, and it's likely to soon be unsupported!
Comment #3
tvn commentedComment #4
MixologicMoving to the customizations queue.
Comment #5
joachim commentedI'm not sure that's the right place for it. "Drupal.org customizations" is a set of custom modules that run on d.org. Flag is not one of those custom modules -- surely the choice of which modules to use to build d.org is outside of that?
Comment #6
drummEither queue is okay for me.
Any followups have a good chance of being in the flag_tracker module.
Comment #7
joachim commented> It's not the recommended 7.x branch, and it's likely to soon be unsupported!
Support for Flag 7.x-2.x ended some months ago.
Comment #8
joachim commentedThis is now a task; I presume this is major due to there being some blocking issues?
Comment #9
joachim commentedFlag 3.x would also allow people to categorize their lists of issues: #1621714: Allow to bookmark/favorite issues without abusing the Assigned field or issue tags.
Comment #10
drummThe blocker here is spending the time to QA this. Especially making sure project issue module's integration continues to function well.
Comment #11
yesct commentedComment #12
japerryAs part of the spam fighting pushes we're doing, I'm in the process of upgrading to flag 3.x
One project we need to investigate is https://www.drupal.org/project/flag_tracker -- its in our build scripts, and it doesn't work with flag 3.x out of the box. I haven't done further investigation, but will unless someone knows of the top of their head why we specifically need it.
I'm starting with using this hash of 3.x, since it has better 2.x upgrade support. It'd be nice if flag just rolled another release ;)
Comment #13
joachim commented> It'd be nice if flag just rolled another release ;)
I was holding out to get some outstanding patches reviewed. I think there's just one left. One of them was the performance fix that will allow spam flags on comments without a flagging query for every single comment -- that's been committed I think.
> One project we need to investigate is https://www.drupal.org/project/flag_tracker -- its in our build scripts, and it doesn't work with flag 3.x out of the box
I think I mentioned somewhere else that flag_tracker is an abomination. It uses Flag merely for the JS flag links, and then has to constantly keep the flagging data and the tracker data synced up both ways!
Comment #14
drummComment #15
drummSome more-specific information on flag tracker #2218345: Doesn't actually need Flag.
Comment #16
joachim commentedAh yes, I knew I'd written more about it somewhere :)
Comment #17
joachim commented> It'd be nice if flag just rolled another release ;)
Done :) Just released Flag 7.x-3.7.
Comment #18
hestenet> Done :) Just released Flag 7.x-3.7.
Awesome - thanks!
Comment #19
drummI ran into #2488122: Error on update from 7.x-2.x to 7.x-3.x (update 7303) on our dev server, which I believe has a similar
tmpdirsetup to production. That should also speed up the deployment with skipping creating some ephemeral keys. Updates 7003 and later took 5 minutes with this patch, and I didn't think to time the earlier updates. That puts us on course for a 30m scheduled downtime (the minimum for real downtimes), rather than maybe 60m.Comment #21
drummAdding deployment notes. We're scheduling this downtime for Monday, 5pm US Pacific time.
Comment #22
drummComment #23
drummComment #24
drummUpdating the version numbers in the deployment notes. Everything is testing well.
Comment #26
drummThis is on staging for final review.
Comment #27
drummThis has been deployed.