Patch to address a bunch of non-functional coding issues:
white space, coding style, unused variables, some inaccurate documentation, and cruft

this is not comprehensive, just a little cleanup

CommentFileSizeAuthor
#1 drealty_daemon-code_cleanup-2119899.patch13.61 KBaaronbauman

Comments

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new drealty_daemon-code_cleanup-2119899.patch13.61 KB

Patch for drealty.daemon.php, which is primarily what i've been working with lately.

alexweber’s picture

alexweber commented
Issue summary: View changes
Status: Needs review » Needs work

Hey Aaron, appreciate the input and patch!

Unfortunately the dev branch has moved on and it no longer applies...

Since it's such a big patch, it's probably better to break it up into smaller, more isolated chunks, so that it's less likely that a commit here or there will make the patch not apply...

Thanks!

shauntyndall’s picture

shauntyndall commented
Related issues: +#1520196: Whitespace cleanups

Relating duplicate issue.

shauntyndall’s picture

shauntyndall commented
Status: Needs work » Fixed

This was addressed as part of 7.x-3.0-rc1. Lots of coding standards improvements. Probably more to accomplished but it needs to be in smaller chunks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.