The numeric check for width displays height as the invalid field and vice versa. Also, the form_set_error call has an invalid field name for the first param so the non-numeric field doesn't get highlighted when the error is triggered. As a side note, since it is a required field there really isn't a need to error out as non-numeric when it is empty as the required error message will show already. Patch to come.

CommentFileSizeAuthor
#1 validation-2117731-1.patch1.22 KBcyu

Comments

cyu’s picture

Status: Active » Needs review
StatusFileSize
new1.22 KB

Patch addresses the 3 issues mentioned in the issue summary.

nvahalik’s picture

Title: Validation fix for fedex settings form » Fix dimension validation checks.
Issue summary: View changes
Status: Needs review » Closed (fixed)

Fixed in -dev.

  • nvahalik committed 6d1ed0a on 7.x-1.x
    Issue #2117731 by cYu: Fix dimension form validation.
    Issue #1969148 by...