First li in ul.links should have 0 padding on the left.

CommentFileSizeAuthor
#2 bootstrap-left-padding-first-li-list-inline-2115941-1.patch368 bytesel7cosmos
#1 bootstrap-left-padding-first-li-list-inline-2115941-1.patch368 bytesel7cosmos
Screen Shot 2013-10-18 at 11.52.57.png36.57 KBtripox

Comments

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented
StatusFileSize
new bootstrap-left-padding-first-li-list-inline-2115941-1.patch368 bytes

It set by bootstrap in type.less

.list-inline {
  .list-unstyled();
  > li {
    display: inline-block;
    padding-left: 5px;
    padding-right: 5px;
  }
}

If necessary, it should be done in override.less

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented
Status: Needs work » Needs review
StatusFileSize
new bootstrap-left-padding-first-li-list-inline-2115941-1.patch368 bytes
markhalliwell’s picture

markhalliwell
Primary language English
commented
Issue summary: View changes
Status: Needs review » Fixed

Thanks @el7cosmos!

Committed 7757ef6 to 7.x-3.x:

Issue #2115941 by el7cosmos, tripox: Remove left padding on first li in ul.links.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

danillonunes’s picture

danillonunes commented

This is plain wrong. Bootstrap already do a margin-left: -5px; on .list-inline so the effect is as there’s 0 padding left on first item. This patch basically breaks the default behaviour. I suggest to revert it.

danillonunes’s picture

danillonunes commented
Status: Closed (fixed) » Needs work
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: tripox » Unassigned
Category: Task » Bug report

At the time (3.0.0) it probably made sense, no doubt this probably isn't compatible with 3.1.1 anymore though :-/

  • Mark Carver committed 7757ef6 on 8.x-3.x.x authored by el7cosmos 
    Issue #2115941 by el7cosmos, tripox: Remove left padding on first li in...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Fixed

  • Mark Carver committed 6039d89 on 7.x-3.x 
    Issue #2115941 by el7cosmos, tripox: Revert "Remove left padding on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.