It would be nice to have drush support.

CommentFileSizeAuthor
#9 browscap-6.x-2.x-drush_get_browser-2115551-9.patch1.08 KBaohrvetpv
#5 interdiff.txt1.27 KBaohrvetpv
#5 2115551-5_browscap_drush_support.patch1.15 KBaohrvetpv
#4 2115551-4_browscap_drush_support.patch1.14 KBaohrvetpv
#3 2115551-3_browscap_drush_support.patch1.14 KBgreggles
#2 drush_browscap_support-2115551-2.patch1.06 KBaohrvetpv
#1 2115551_drush_browscap_support.patch931 bytesgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 2115551_drush_browscap_support.patch931 bytes
aohrvetpv’s picture

aohrvetpv commented
Issue summary: View changes
StatusFileSize
new drush_browscap_support-2115551-2.patch1.06 KB

I think this Drush command would be useful.

New patch:
- Changed per coding standards. (Eliminated all Coder Review warnings.)
- Removed "delimited list of spreads (e.g. mayonnaise, mustard)" from argument description. (This was a joke, I think.)
- Changed example to use user agent enclosed with single quotes instead of double quotes. I think with a shell like Bash there is risk that characters of a double-quoted user agent string might be interpreted as shell syntax. Single quotes seem safer.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 2115551-3_browscap_drush_support.patch1.14 KB

Updated file after #2287159: Disable automatic downloads by default, provide drush integration.

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new 2115551-4_browscap_drush_support.patch1.14 KB

Remove second blank line between function declarations.

(The second line is not against coding standards, but seemed inconsistent with the single blank line gap between other functions. If the second blank line had a purpose, please disregard.)

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new 2115551-5_browscap_drush_support.patch1.15 KB
new interdiff.txt1.27 KB

Maybe it would be better to allow the --format option and default to JSON?

I doubt this patch is complete.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Very cool! Thanks for using that format option.

  • greggles committed abf81b3 on 7.x-2.x 
    Issue #2115551 by AohRveTPV, greggles: drush command for browscap
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Great, committed! Thanks!

aohrvetpv’s picture

aohrvetpv commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new browscap-6.x-2.x-drush_get_browser-2115551-9.patch1.08 KB
lahoosascoots’s picture

lahoosascoots commented

subscribing for future D8 porting reminder

astonvictor’s picture

astonvictor commented
Status: Needs review » Closed (outdated)

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Closed (outdated) » Fixed

It was fixed in 7.x-2.x and not backported, so we can use this status which is a little better.

astonvictor’s picture

astonvictor commented

ok, thanks for the update

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.