Updated: Comment #0

Problem/Motivation

The function is already duplicated in views.module's NodeContextualLinksTest and config_translation.module is duplicating it a third time currently. This will happen in contrib a lot more.

Proposed resolution

Move the function to WebTestBase. Most test cases won't use it, but I still think it makes sense to provide it there. Since we don't have traits, there's nowhere else to put it.

Remaining tasks

Review patch.

User interface changes

None.

API changes

Only an API addition: WebTestBase::renderContextualLinks

CommentFileSizeAuthor
#12 move-2113679-12.patch4.34 KBmanuel garcia
#9 2113679-9.patch134.69 KBrasikap
#1 2113679-1.patch4.44 KBtstoeckler

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new 2113679-1.patch4.44 KB

Here we go.

dawehner’s picture

dawehner
Primary language German
commented

Looks solid as it is, even I am wondering whether this is used that often that it really is worth to copy to the base class.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Yeah, with the new drupalPost() I must admit I thought the same thing when rolling this. config_translation.module still had the hold version at the time, just like views.module which is what made this wort it. We could just as well inline it, I don't feel strongly about that.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Assigned: tstoeckler » Unassigned
Issue summary: View changes

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Version: 8.1.x-dev » 8.2.x-dev
Status: Needs review » Needs work
Issue tags: +Needs reroll

This no longer applies.

Instead of moving to WebTestBase, perhaps moving to a trait that can be used as needed would be better?

It's also in use in several more places now:

modules/config_translation/src/Tests/ConfigTranslationUiTest.php
1096:  protected function renderContextualLinks($ids, $current_path) {

modules/content_translation/src/Tests/ContentTranslationContextualLinksTest.php
149:  protected function renderContextualLinks($ids, $current_path) {

modules/contextual/src/Tests/ContextualDynamicContextTest.php
180:  protected function renderContextualLinks($ids, $current_path) {

modules/node/src/Tests/Views/NodeContextualLinksTest.php
64:  protected function renderContextualLinks($ids, $current_path) {
ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Issue tags: +DrupalMumbaiCodeSprint15

We will take this issue on Drupal Mumbai code sprint today.

rasikap’s picture

rasikap commented
Assigned: Unassigned » rasikap
rasikap’s picture

rasikap commented
Assigned: rasikap » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2113679-9.patch134.69 KB

Adding rerolled patch.
Following files were resolved for conflicts :
1. core/modules/contextual/src/Tests/ContextualDynamicContextTest.php
2. core/modules/node/src/Tests/Views/NodeContextualLinksTest.php
3. core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work

That was a bad merge, as WebTestBase has moved in the meantime.

I also agree with #6, using a trait for this makes a lot of sense. We should also consider the ongoing conversion to BrowserTestBase, so would be great to have some input from @klausi/@dawehner/... if that is affected by this or vice versa.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

manuel garcia’s picture

manuel garcia commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new move-2113679-12.patch4.34 KB

Reroll of #1

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #need-reveiw-queue. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge require as a guide.

Reviewing the patch against 10.1.x and see NodeContextualLinksTest no longer has a function for contextualLinks. Is this still a valid task since only ContextualDynamicContextTest has the function now?

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there hasn't been a follow up going to close for now. If still a valid task please reopen.