Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.

Comments

bneil’s picture

Assigned: bneil » Unassigned
Status: Active » Needs review
StatusFileSize
new3.18 KB

Fixed

FILE: ...al/media_dev/profiles/media_dev/modules/file_entity/file_entity.install
--------------------------------------------------------------------------------
FOUND 16 ERROR(S) AND 3 WARNING(S) AFFECTING 17 LINE(S)
--------------------------------------------------------------------------------
 104 | WARNING | Line exceeds 80 characters; contains 81 characters
 204 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
     |         | question marks
 295 | ERROR   | Function comment short description must be on a single line
 502 | ERROR   | Expected 1 space after comma in function call; 2 found
 507 | ERROR   | Function comment short description must be on a single line
 544 | ERROR   | Function comment short description must be on a single line
 549 | WARNING | There must be no blank line following an inline comment
 660 | WARNING | There must be no blank line following an inline comment
 825 | ERROR   | Case breaking statements must be followed by a single blank
     |         | line
 828 | ERROR   | Case breaking statements must be followed by a single blank
     |         | line
 831 | ERROR   | Case breaking statements must be followed by a single blank
     |         | line
 834 | ERROR   | Case breaking statements must be followed by a single blank
     |         | line
 837 | ERROR   | Case breaking statements must be followed by a single blank
     |         | line
--------------------------------------------------------------------------------

Not fixed

FILE: ...al/media_dev/profiles/media_dev/modules/file_entity/file_entity.install
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
 223 | ERROR | Do not use t() or st() in installation phase hooks, use $t =
     |       | get_t() to retrieve the appropriate localization function name
 311 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
 332 | ERROR | There should be no white space after an opening "{"
 332 | ERROR | There should be no white space before a closing "}"
 332 | ERROR | Closing brace must be on a line by itself
 816 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
--------------------------------------------------------------------------------

I'm not sure about the added white space in the empty update hook, if that is there by design or not.

I'll post a follow up issue for "223 | ERROR | Do not use t() or st() in installation phase hooks, use $t = get_t() to retrieve the appropriate localization function name"

devin carlson’s picture

Status: Needs review » Fixed

The patch in #1 looks good and I agree on a follow up issue to address the remaining issues, including $t = get_t().

Committed #1 to File entity 7.x-2.x.

bneil’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.