Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | file_entity-install_coding_standards-2113325-1.patch | 3.18 KB | bneil |
Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | file_entity-install_coding_standards-2113325-1.patch | 3.18 KB | bneil |
Comments
Comment #1
bneil commentedFixed
Not fixed
I'm not sure about the added white space in the empty update hook, if that is there by design or not.
I'll post a follow up issue for "223 | ERROR | Do not use t() or st() in installation phase hooks, use $t = get_t() to retrieve the appropriate localization function name"
Comment #2
devin carlson commentedThe patch in #1 looks good and I agree on a follow up issue to address the remaining issues, including
$t = get_t().Committed #1 to File entity 7.x-2.x.
Comment #3
bneil commentedFollow up: #2114293: file_entity.install coding standards followup