file_entity.file_api.inc coding standards cleanup [#2113253]

Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.

Comment	File	Size	Author
#1	file_entity-fileapiinc_coding_standards-2113253-1.patch	8.6 KB	bneil
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bneil CreditAttribution: bneil commented 16 October 2013 at 15:05

Assigned:	bneil	» Unassigned
Status:	Active	» Needs review

File	Size
file_entity-fileapiinc_coding_standards-2113253-1.patch	8.6 KB

Fixed

FILE: ...dia_dev/profiles/media_dev/modules/file_entity/file_entity.file_api.inc
--------------------------------------------------------------------------------
FOUND 35 ERROR(S) AND 8 WARNING(S) AFFECTING 40 LINE(S)
--------------------------------------------------------------------------------
  16 | ERROR   | Missing parameter type at position 1
  20 | ERROR   | Data type of return value is missing
  43 | WARNING | Line exceeds 80 characters; contains 91 characters
  54 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
     |         | question marks
  61 | ERROR   | Missing parameter type at position 1
  63 | ERROR   | Missing parameter type at position 2
  65 | ERROR   | Missing parameter type at position 3
  67 | ERROR   | Missing parameter type at position 4
  71 | ERROR   | Data type of return value is missing
  96 | ERROR   | Missing parameter type at position 1
  98 | ERROR   | Missing parameter type at position 2
 100 | ERROR   | Missing parameter type at position 3
 104 | ERROR   | Data type of return value is missing
 144 | ERROR   | Missing parameter type at position 1
 146 | ERROR   | Missing parameter type at position 2
 148 | ERROR   | Missing parameter type at position 3
 202 | ERROR   | Missing parameter type at position 1
 204 | ERROR   | Missing parameter type at position 2
 208 | ERROR   | Missing parameter type at position 3
 212 | ERROR   | Data type of return value is missing
 285 | WARNING | Line exceeds 80 characters; contains 85 characters
 299 | ERROR   | Missing parameter type at position 1
 301 | ERROR   | Missing parameter type at position 2
 304 | ERROR   | Data type of return value is missing
 436 | ERROR   | Invalid @param data type, expected bool but found boolean
 560 | ERROR   | Missing parameter type at position 1
 612 | ERROR   | Missing parameter type at position 1
 615 | ERROR   | Data type of return value is missing
 630 | WARNING | Line exceeds 80 characters; contains 142 characters
 633 | ERROR   | Expected 1 space before "="; 0 found
 633 | ERROR   | Expected 1 space after "="; 0 found
 639 | ERROR   | Expected 1 space before "/"; 0 found
 639 | ERROR   | Expected 1 space after "/"; 0 found
 667 | ERROR   | Missing parameter type at position 1
 669 | ERROR   | Missing parameter type at position 2
 674 | ERROR   | Data type of return value is missing
 677 | WARNING | Line exceeds 80 characters; contains 85 characters
 721 | WARNING | Line exceeds 80 characters; contains 83 characters
 722 | WARNING | There must be no blank line following an inline comment
 722 | ERROR   | No space before comment text; expected "//
     |         | field_attach_delete('file', $file);" but found
     |         | "//field_attach_delete('file', $file);"
 725 | WARNING | Line exceeds 80 characters; contains 87 characters
 726 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------

Not fixed

FILE: ...dia_dev/profiles/media_dev/modules/file_entity/file_entity.file_api.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 341 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
--------------------------------------------------------------------------------