Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There is a comment in node.module file that should be deleted because the mentioned issue is fixed:
function template_preprocess_node(&$variables) {
$variables['view_mode'] = $variables['elements']['#view_mode'];
// Provide a distinct $teaser boolean.
$variables['teaser'] = $variables['view_mode'] == 'teaser';
$variables['node'] = $variables['elements']['#node'];
$node = $variables['node'];
$variables['date'] = format_date($node->getCreatedTime());
// @todo Change 'name' to 'author' and also convert to a render array pending
// http://drupal.org/node/1941286.
Proposed resolution
Delete the following comment:
// @todo Change 'name' to 'author' and also convert to a render array pending
// http://drupal.org/node/1941286.
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Related Issues
N/A
Comment | File | Size | Author |
---|---|---|---|
#1 | 2113221-1.patch | 552 bytes | sidharthap |
Comments
Comment #1
sidharthapHere is the patch file.
Comment #2
herom CreditAttribution: herom commentedconfirming the issue, and the proposed patch fix.
Comment #3
Xano#1: 2113221-1.patch queued for re-testing.
Comment #4
alexpottCommitted 6829a65 and pushed to 8.x. Thanks!
Comment #5
tstoecklerIn fact the variable is still called $name, and per the todo should perhaps be renamed to $author?
Comment #6
herom CreditAttribution: herom commented@tstoeckler yup. don't know how I missed that part :(
what should be done now?