Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.

Comments

bneil’s picture

Assigned: bneil » Unassigned
Status: Active » Needs review
StatusFileSize
new5.96 KB

Fixed

FILE: /var/www/drupal-7-pareview/pareview_temp/file_entity.pages.inc
--------------------------------------------------------------------------------
FOUND 22 ERROR(S) AND 6 WARNING(S) AFFECTING 22 LINE(S)
--------------------------------------------------------------------------------
71 | ERROR | Case breaking statements must be followed by a single blank
| | line
73 | ERROR | Case breaking statements must be followed by a single blank
| | line
75 | ERROR | Case breaking statements must be followed by a single blank
| | line
206 | WARNING | Line exceeds 80 characters; contains 84 characters
291 | WARNING | Line exceeds 80 characters; contains 85 characters
291 | ERROR | No space before comment text; expected "// if the previous
| | button was hit, the step checking order should be reversed 3,
| | 2" but found "//if the previous button was hit, the step
| | checking order should be reversed 3, 2"
291 | ERROR | Inline comments must start with a capital letter
296 | ERROR | No space before comment text; expected "// Check if we can
| | skip step 2 and 3" but found "//Check if we can skip step 2
| | and 3"
300 | ERROR | No space before comment text; expected "// check if we can
| | skip step 2" but found "//check if we can skip step 2"
300 | ERROR | Inline comments must start with a capital letter
304 | WARNING | Line exceeds 80 characters; contains 85 characters
315 | ERROR | No space before comment text; expected "// check if we can
| | skip step 3" but found "//check if we can skip step 3"
315 | ERROR | Inline comments must start with a capital letter
318 | WARNING | Line exceeds 80 characters; contains 90 characters
415 | ERROR | Data type of return value is missing
434 | ERROR | Missing function doc comment
461 | ERROR | Missing function doc comment
466 | WARNING | Line exceeds 80 characters; contains 104 characters
473 | WARNING | There must be no blank line following an inline comment
573 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
603 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
728 | ERROR | Inline comments must start with a capital letter
728 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
728 | ERROR | Comments may not appear after statements.
--------------------------------------------------------------------------------

Did not fix

FILE: .../media_dev/profiles/media_dev/modules/file_entity/file_entity.pages.inc
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
  16 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
  18 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
  67 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
 514 | ERROR | If the line declaring an array spans longer than 80 characters,
     |       | each element should be broken into its own line
--------------------------------------------------------------------------------
devin carlson’s picture

Status: Needs review » Fixed

#1 looks good.

Committed to File entity 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.