Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.

CommentFileSizeAuthor
#1 file_entity-apiphp-2111817-1.patch6.18 KBbneil

Comments

bneil’s picture

Assigned: bneil » Unassigned
Status: Active » Needs review
StatusFileSize
new6.18 KB

Fixed

FILE: /var/www/drupal-7-pareview/pareview_temp/file_entity.api.php
--------------------------------------------------------------------------------
FOUND 26 ERROR(S) AND 2 WARNING(S) AFFECTING 27 LINE(S)
--------------------------------------------------------------------------------
62 | ERROR | Data type of return value is missing
77 | ERROR | Missing parameter type at position 1
132 | ERROR | Data type of return value is missing
167 | ERROR | Missing parameter type at position 1
174 | ERROR | Missing parameter type at position 2
177 | ERROR | Missing parameter type at position 3
181 | ERROR | Data type of return value is missing
203 | ERROR | Missing parameter type at position 1
221 | ERROR | Missing parameter type at position 1
236 | ERROR | If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own line
245 | ERROR | Missing parameter type at position 1
283 | ERROR | Data type of return value is missing
312 | WARNING | Line exceeds 80 characters; contains 81 characters
315 | WARNING | Line exceeds 80 characters; contains 81 characters
328 | ERROR | Missing parameter type at position 1
330 | ERROR | Missing parameter type at position 2
342 | ERROR | Missing parameter type at position 1
345 | ERROR | Data type of return value is missing
345 | ERROR | Invalid @return data type, expected array but found Array
362 | ERROR | Missing parameter type at position 1
364 | ERROR | Missing parameter type at position 2
372 | ERROR | Missing function doc comment
376 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------

Not fixed

I haven't fixed the following issues, perhaps someone else can document the functions that need documentation.

FILE: ...al/media_dev/profiles/media_dev/modules/file_entity/file_entity.api.php
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
  85 | ERROR | Missing short description in function doc comment
  95 | ERROR | Missing short description in function doc comment
 105 | ERROR | Missing short description in function doc comment
 111 | ERROR | Missing short description in function doc comment
 117 | ERROR | Missing short description in function doc comment
--------------------------------------------------------------------------------
devin carlson’s picture

Status: Needs review » Fixed

You could debate a line or two but overall #1 is a great improvement, thanks!

Committed to File entity 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.