Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.

CommentFileSizeAuthor
#1 file_entity-field_file_inc-2111801-1.patch2.64 KBbneil

Comments

bneil’s picture

bneil commented
Assigned: bneil » Unassigned
Status: Active » Needs review
StatusFileSize
new file_entity-field_file_inc-2111801-1.patch2.64 KB

Fixed

--------------------------------------------------------------------------------
FILE: ...l/media_dev/profiles/media_dev/modules/file_entity/file_entity.field.inc
FOUND 4 ERROR(S) AND 1 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
 267 | WARNING | Line exceeds 80 characters; contains 85 characters
 344 | ERROR   | Inline comments must start with a capital letter
 344 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
     |         | question marks
 378 | ERROR   | Inline comments must start with a capital letter
 378 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
     |         | question marks
--------------------------------------------------------------------------------

FILE: ...l/media_dev/profiles/media_dev/modules/file_entity/file_entity.file.inc
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 3 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
  80 | WARNING | Format should be "* Implements hook_foo().", "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.".
 146 | WARNING | Line exceeds 80 characters; contains 81 characters
 147 | WARNING | Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------------

FILE: .../drupal/media_dev/profiles/media_dev/modules/file_entity/file_entity.js
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | Additional whitespace found at start of file
--------------------------------------------------------------------------------
devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

The changes look good.

Committed #1 to File entity 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.