If the local translator is used with tmgmt_server a job may have a comment attached. The current state is that the comment is just "check_plain-ed" and any meaningful formatting is lost. Using check_markup() with defaults should be just fine.

CommentFileSizeAuthor
#4 tmgmt-better_job_comment_formatting-2111435-2.patch1.23 KBblueminds
#1 tmgmt-better_job_comment_formatting-2111435-1.patch1.23 KBblueminds

Comments

blueminds’s picture

blueminds commented
Status: Active » Needs review
StatusFileSize
new tmgmt-better_job_comment_formatting-2111435-1.patch1.23 KB

see the patch

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Hm, not sure. We don't know what the default form is, it could just as well be plain text too.

filter_xss() might be the better approach here?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
blueminds’s picture

blueminds commented
Status: Needs work » Needs review
StatusFileSize
new tmgmt-better_job_comment_formatting-2111435-2.patch1.23 KB

here we go

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, committed and pushed.

Status: Fixed » Closed (fixed)
Issue tags: +

Automatically closed - issue fixed for 2 weeks with no activity.