Closed (fixed)
Project:
Panopoly
Version:
7.x-1.0-rc5
Component:
Admin
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Oct 2013 at 18:56 UTC
Updated:
28 May 2014 at 22:30 UTC
Jump to comment: Most recent
Hello, I am developing a site using Panopoly (panopoly-7.x-1.0-rc5) distribution. I tried to add a pane of Menu Block. I clicked the "Add submenu" button. At the settings window, I could not find "Fixed parent item" setting. I wanted that setting because I want to display a submenu of a specific parent item.
Comments
Comment #1
lsolesen commentedThis has been explicitly ruled out,
However, is that wise?
Comment #2
caschbre commented@Mark... is this still an issue? I'm not able to reproduce it.
Comment #3
lsolesen commented@caschbre I confirmed this in #1 - it is explicitly disabled unless it has been changed in the code now?
Comment #4
caschbre commentedSorry... what I mean is that I'm not experiencing the issue (http://drupal.org/node/1649112) with menu_block outside of Panopoly.
Let me check my other project to see if we applied any other patches.
Comment #5
lsolesen commentedAh.
Comment #6
caschbre commentedOk, I did some more testing and here's what I'm experiencing.
If I enable the block module and then create a new menu_block I don't have any issues with the block retaining my 'fixed parent item' setting. So this is probably why I wasn't having any issues in my non-panopoly sites.
However, if I use the submenu pane widget it doesn't seem to be retaining that setting.
Could this be related to configuring through the ctools modal? Ajax at play here?
Comment #7
caschbre commentedI still have not resolved this yet but just adding more notes.
I removed the panopoly_widgets form alter of menu_block so I had access to the advanced settings. I changed the fixed parent item value and it does look like it is saving. What is weird is that when you load up the config form again the select box isn't selecting that value even though the form_states has it.
Not sure why it's happening in ctools/panels but not in the block admin UI.
Comment #8
lsolesen commentedCaschbre also check out the behag test for the submenu for similar issue.
Comment #9
fredsted commentedHas anyone found a way to select a fixed parent item on a menu?
When I add a new Block, the "Fixed parent item" combobox is hidden with
display:none;- if I disable that and select a value, I get an error message saying it's a invalid choice!I'd love to be able to contribute some code (it seems like this is a TODO, so I could do it since I really need it) I just don't know where to start. Any ideas?
The reason behind this is I have my News "overview" page (list with all news, categories, etc) under a parent page. When you click a news article I'd like to display the submenu, but I can't, since news articles apparently don't have a parent page.
Comment #10
dsnopek@caschbre: The Panel's pane is defined by the menu_block module itself, so if there is an issue with it, it's likely still in the upstream module - even if the block works correctly.
There was recently a new version of menu_block released: #2259793: Update 'menu_block' module to 2.4
I haven't had a chance to test it yet, but it be worth checking to see if the problem got fixed!
Comment #11
dsnopekI just did the upgrade to menu_block 2.4, so I decided to test if it fixed this issue.
I was able to reproduce the problem that @caschbre had with the settings not saving in menu_block 2.3. After upgrading to 2.4, it worked fine! So, I think there is no longer any reason to hide that setting from the form. :-)
Comment #13
dsnopekCommitted!