I'm adding video atom from youtube RSS, but created atoms don't have width/set and thumbnail.
Here a patch to fix scald_youtube_register function.

CommentFileSizeAuthor
#4 scald_youtube-scald_youtube_vimeo_register-2109753.patch1.86 KBraphael apard
#2 scald_vimeo-scald_vimeo_register.patch942 bytesraphael apard
#1 scald_youtube-scald_youtube_register-1.patch960 bytesraphael apard
scald_youtube-scald_youtube_register.patch1.61 KBraphael apard

Comments

raphael apard’s picture

raphael apard commented
StatusFileSize
new scald_youtube-scald_youtube_register-1.patch960 bytes

Same patch without debug() line.

raphael apard’s picture

raphael apard commented
StatusFileSize
new scald_vimeo-scald_vimeo_register.patch942 bytes

And here the patch for scald_vimeo

jcisio’s picture

jcisio commented
Status: Active » Needs review

Make as NR to launch test bots. However could you combine them in one patch?

raphael apard’s picture

raphael apard commented
StatusFileSize
new scald_youtube-scald_youtube_vimeo_register-2109753.patch1.86 KB

Here to combined patch .
How about the file status for thumbnail ? It's set to 0 in dailymotion provider.

jcisio’s picture

jcisio commented

The status is not important. When you save the entity (atom), its files will be marked as permanent.

jcisio’s picture

jcisio commented
Status: Needs review » Fixed

Committed 37e48b4. They are unused functions anyway. I think we need follow-up issue to refactor duplicate code.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.